[issue30936] json module ref leaks detected by test_json

[STINNER Victor]

STINNER Victor added the comment:

Thanks for the fixes. I checked manually 2.7, 3.5, 3.6 and master branches with 
"./python -m test -R 3:3 test_json": no more leak!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30936] json module ref leaks detected by test_json

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for opening this issue Segev.

Tests added in issue30911 exposed existing leak in 3.5 and 3.6. It was not 
exposed in 3.7 due to different code for sort_keys. But there was a leak when 
sorting keys is failed. I added a new test for this case.

2.7 is not affected because C speedup is not implemented for sort_keys in 2.7.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30936] json module ref leaks detected by test_json

[Serhiy Storchaka]

Serhiy Storchaka added the comment:


New changeset 45c471c04553d7e4cb5c328ea1ab02d6716f2bab by Serhiy Storchaka in 
branch '3.5':
[3.5] bpo-30936: Fix a reference leak in json when fail to sort keys. 
(GH-2712). (#2728)
https://github.com/python/cpython/commit/45c471c04553d7e4cb5c328ea1ab02d6716f2bab


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30936] json module ref leaks detected by test_json

[Serhiy Storchaka]

Serhiy Storchaka added the comment:


New changeset a819e5e1e66a1a5f9a7073c8a1ff3c3f304c917b by Serhiy Storchaka in 
branch '3.6':
[3.6] bpo-30936: Fix a reference leak in json when fail to sort keys. 
(GH-2712). (#2727)
https://github.com/python/cpython/commit/a819e5e1e66a1a5f9a7073c8a1ff3c3f304c917b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30936] json module ref leaks detected by test_json

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +2788

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30936] json module ref leaks detected by test_json

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +2787

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30936] json module ref leaks detected by test_json

[Serhiy Storchaka]

Serhiy Storchaka added the comment:


New changeset 49f6449ef4b81537c19b82329caaf60596c516c2 by Serhiy Storchaka in 
branch 'master':
bpo-30936: Fix a reference leak in json when fail to sort keys. (#2712)
https://github.com/python/cpython/commit/49f6449ef4b81537c19b82329caaf60596c516c2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30936] json module ref leaks detected by test_json

[STINNER Victor]

STINNER Victor added the comment:

On Python 3.6, the leaking test is:

test.test_json.test_speedups.TestEncode.test_bad_bool_args

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30936] json module ref leaks detected by test_json

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
stage:  -> patch review
versions: +Python 2.7, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30936] json module ref leaks detected by test_json

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +2776

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30936] json module ref leaks detected by test_json

[Segev Finer]

New submission from Segev Finer:

>From builtbots:

test_json leaked [4, 4, 4] references, sum=12
test_json leaked [3, 3, 3] memory blocks, sum=9
1 test failed again:
test_json

Probably unearthed by:
https://github.com/python/cpython/pull/2692
https://github.com/python/cpython/pull/2693

--
components: Extension Modules
messages: 298391
nosy: Segev Finer, haypo, serhiy.storchaka
priority: normal
severity: normal
status: open
title: json module ref leaks detected by test_json
type: resource usage
versions: Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com