[issue31002] IDLE: Add tests for configdialog keys tab

[Terry J. Reedy]

Terry J. Reedy added the comment:

Lines not yet covered in keys group, other than deactivate_current_config and 
activate_config_changes functions:

def save_new_key_set
if not idleConf.userCfg['keys'].has_section(keyset_name):
# never false - minor issue

def delete_custom_keys
if not item_list:
# never false hence following never executed
else: self.customlist.SetMenu(item_list, item_list[0])

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Terry J. Reedy]

Terry J. Reedy added the comment:

Great work. Thank you.
Next: #31205, #31001, #31206, then ...

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset a31459008c5b3230363d155a2e8616664dc4f0c6 by Terry Jan Reedy in 
branch '3.6':
[3.6] bpo-31002: IDLE: Add tests for configdialog keys tab (GH-2996) (#3092)
https://github.com/python/cpython/commit/a31459008c5b3230363d155a2e8616664dc4f0c6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
pull_requests: +3132

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 2f8964634918bdf09107c49a2d5ca62460091e54 by Terry Jan Reedy 
(Cheryl Sabella) in branch 'master':
bpo-31002: IDLE: Add tests for configdialog keys tab (#2996)
https://github.com/python/cpython/commit/2f8964634918bdf09107c49a2d5ca62460091e54


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Terry J. Reedy]

Terry J. Reedy added the comment:

I have thought about factoring out common test code into helper functions 
either within test_configdialog or in a new module.  One example: simulate a 
click on a listbox, with common before and after code.  Another: Testing the 
group of selection widgets on both theme and keys pages. (If I were not 
planning to replace this group, we could factor out a SelectionFrame and put an 
instance on each page.)

We might do some such refactoring after this, before HighPageTest.  Keep notes 
on redundancies you notice that might be candidates.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Terry J. Reedy]

Terry J. Reedy added the comment:

I am not sure I agree with all your suggested name changes.  But I am looking 
as more substantive issues first.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Cheryl Sabella]

Cheryl Sabella added the comment:

I tried to minimize the changes to configdialog.  There were more I wanted to 
make, like reorganizing the order of the functions, but I didn't want to make 
the diff too crazy.  I changed some variable names because all of them had 
'keys' in it and I couldn't keep track of them.  It was almost as descriptive 
as single letter variables!  ;-)   I think I made the new names inline with 
what had been done on the font and general tabs.  Again, there were more 
renaming changes I wanted to make (such as key_set to keyset), but I didn't 
want every line to be a diff.

Also, I used the name 'keyset' to refer to the section names and the 
keybindings to refer to the option:value pairs.  Some old vars in configdialog 
weren't changed to reflect this 100%, but the comment should be correct.

I did not include deactivate_current_config and activate_config__changes since 
those are not really specific to keys.  There are also invoked from themes and 
from apply.

I have notes for some of the other coding changes I'd like to make once this is 
in its own class.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Cheryl Sabella]

Changes by Cheryl Sabella :


--
pull_requests: +3032

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Cheryl Sabella]

Cheryl Sabella added the comment:

I'm making good progress on this.  I should be able to open the PR tomorrow.  
It's definitely non-trivial, but using your font and general tests as a guide 
has been invaluable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Terry J. Reedy]

Terry J. Reedy added the comment:

Great.  It is non-trivial, so I don't expect perfection first try.  Please 
revise docstring with explanation of how page works, like with Font and General 
pages.  I finished tests using those explanations as a guide.  They are also a 
guide for review.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Cheryl Sabella]

New submission from Cheryl Sabella:

I'm working on the tests for this.

--
nosy: +csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31002] IDLE: Add tests for configdialog keys tab

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
assignee: terry.reedy
components: IDLE
nosy: terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: Add tests for configdialog keys tab
type: enhancement
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com