[issue31160] Enhance support.reap_children()

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +18675
pull_request: https://github.com/python/cpython/pull/19312

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[Michael Felt]

Change by Michael Felt :


--
pull_requests: +18670
pull_request: https://github.com/python/cpython/pull/19308

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor  added the comment:

> Pablo Galindo opened bpo-40140, let's use this one.

Note: Oops, Batuhan created it, Pablo only commented.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor  added the comment:

> Please open a new issue. This one is closed.

Pablo Galindo opened bpo-40140, let's use this one.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor  added the comment:

> I think something is not yet what it needs to be: (...)

https://buildbot.python.org/all/#/builders/227/builds/571 build failed but it 
has my commit 16d75675d2ad2454f6dfbf333c94e6237df36018. Ok, something failed.

Please open a new issue. This one is closed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[Michael Felt]

Michael Felt  added the comment:

I think something is not yet what it needs to be:

the bots both finish test with:

test_zip_pickle (test.test_builtin.BuiltinTest) ... ok
Timeout (0:15:00)!
Thread 0x0001 (most recent call first):
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/support/__init__.py",
 line 3435 in wait_process
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/test_builtin.py",
 line 1898 in run_child
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/test_builtin.py",
 line 1952 in test_input_no_stdout_fileno
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/unittest/case.py", 
line 616 in _callTestMethod
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/unittest/case.py", 
line 659 in run
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/unittest/case.py", 
line 719 in __call__
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/unittest/suite.py", 
line 122 in run
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/unittest/suite.py", 
line 84 in __call__
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/unittest/suite.py", 
line 122 in run
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/unittest/suite.py", 
line 84 in __call__
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/unittest/suite.py", 
line 122 in run
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/unittest/suite.py", 
line 84 in __call__
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/unittest/runner.py",
 line 176 in run
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/support/__init__.py",
 line 2079 in _run_suite
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/support/__init__.py",
 line 2201 in run_unittest
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/libregrtest/runtest.py",
 line 209 in _test_module
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/libregrtest/runtest.py",
 line 234 in _runtest_inner2
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/libregrtest/runtest.py",
 line 270 in _runtest_inner
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/libregrtest/runtest.py",
 line 153 in _runtest
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/libregrtest/runtest.py",
 line 193 in runtest
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/libregrtest/main.py",
 line 318 in rerun_failed_tests
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/libregrtest/main.py",
 line 691 in _main
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/libregrtest/main.py",
 line 634 in main
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/libregrtest/main.py",
 line 712 in main
  File 
"/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/__main__.py", 
line 2 in 
  File "/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/runpy.py", 
line 87 in _run_code
  File "/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/runpy.py", 
line 197 in _run_module_as_main
make: 1254-004 The error code from the last command is 1.
Stop.
program finished with exit code 2
elapsedTime=3501.292487
test_input_no_stdout_fileno (test.test_builtin.PtyTests) ... 

And the bot status is still FAIL (aka red): failed test (failure) uploading 
test-results.xml (failure)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[Michael Felt]

Michael Felt  added the comment:

Ah - great. Sorry for the noise then.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor  added the comment:

> Ah - great. Sorry for the noise then.

It's not noise, it is useful :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor  added the comment:

> With PR19263 The AIX bots are now red.

I know, I saw and I already pushed fixes.

> NameError: name 'signal' is not defined

Fixed by commit afeaea2d6e346f627b24cc9e84e2986a7266a70e.

> 1 test failed again: test_builtin

Fixed by commit 16d75675d2ad2454f6dfbf333c94e6237df36018.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[Michael Felt]

Michael Felt  added the comment:

With PR19263 The AIX bots are now red.

==
ERROR: test_input_no_stdout_fileno (test.test_builtin.PtyTests)
--
Traceback (most recent call last):
  File 
"/home/shager/cpython-buildarea/3.x.edelsohn-aix-ppc64/build/Lib/test/test_builtin.py",
 line 1952, in test_input_no_stdout_fileno
lines = self.run_child(child, b"quux\r")
  File 
"/home/shager/cpython-buildarea/3.x.edelsohn-aix-ppc64/build/Lib/test/test_builtin.py",
 line 1898, in run_child
support.wait_process(pid, exitcode=0)
  File 
"/home/shager/cpython-buildarea/3.x.edelsohn-aix-ppc64/build/Lib/test/support/__init__.py",
 line 3432, in wait_process
os.kill(pid, signal.SIGKILL)
NameError: name 'signal' is not defined
--
Ran 101 tests in 30.348s
FAILED (errors=1, skipped=7)
1 test failed again:
test_builtin

+++
The Buildbot has detected a failed build on builder PPC64 AIX 3.x while 
building python/cpython.
Full details are available at:
https://buildbot.python.org/all/#builders/227/builds/565

Buildbot URL: https://buildbot.python.org/all/

Worker for this Build: edelsohn-aix-ppc64
Worker for this Build: aixtools-aix-power6

--
nosy: +Michael.Felt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 16d75675d2ad2454f6dfbf333c94e6237df36018 by Victor Stinner in 
branch 'master':
bpo-31160: Fix race condition in test_os.PtyTests (GH-19263)
https://github.com/python/cpython/commit/16d75675d2ad2454f6dfbf333c94e6237df36018


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +18619
pull_request: https://github.com/python/cpython/pull/19263

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:

I pushed the most important change: reap_children() now makes tests fail with 
ENV_CHANGED on warning, so I close the issue.

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:


New changeset 1247e2cda514d7a73187e0b53ec8c35d87a34a84 by Victor Stinner in 
branch '2.7':
[2.7] bpo-31160: Backport reap_children fixes from master to 2.7 (#3063)
https://github.com/python/cpython/commit/1247e2cda514d7a73187e0b53ec8c35d87a34a84


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3097

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:


New changeset 719a15b32587de6c4add4385ee3f84a20711340f by Victor Stinner in 
branch '3.6':
[3.6] bpo-31160: Backport reap_children() fixes from master to 3.6 (#3060)
https://github.com/python/cpython/commit/719a15b32587de6c4add4385ee3f84a20711340f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3095

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:

bpo-31151 fixed test_socketserver.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:


New changeset 6c8c2943d996b59a48d331f61f22cbe72933910e by Victor Stinner in 
branch 'master':
bpo-31160: test_tempfile: Fix reap_children() warning (#3056)
https://github.com/python/cpython/commit/6c8c2943d996b59a48d331f61f22cbe72933910e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3091

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:

bpo-31173 fixed a leaked child process in test_subprocess.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:

> New changeset 4baca1b0f7325032598cd38e7ceffc79b616d255 by Victor Stinner in 
> branch 'master':
> bpo-31160: Fix test_builtin for zombie process (#3043)

This change introduced a regression:

http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.x/builds/1159/steps/test/logs/stdio

==
FAIL: test_input_no_stdout_fileno (test.test_builtin.PtyTests)
--
Traceback (most recent call last):
  File 
"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_builtin.py", 
line 1624, in test_input_no_stdout_fileno
lines = self.run_child(child, b"quux\r")
  File 
"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_builtin.py", 
line 1573, in run_child
self.assertEqual(status, 0)
AssertionError: 1 != 0

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3080

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:


New changeset da5e9301877346942fa4279612750d6a09e05153 by Victor Stinner in 
branch 'master':
bpo-31160: Fix test_random for zombie process (#3045)
https://github.com/python/cpython/commit/da5e9301877346942fa4279612750d6a09e05153


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:


New changeset e3510d74aacc477c30f42f2b941d69689bbc478e by Victor Stinner in 
branch 'master':
bpo-31160: regrtest now reaps child processes (#3044)
https://github.com/python/cpython/commit/e3510d74aacc477c30f42f2b941d69689bbc478e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:


New changeset 4baca1b0f7325032598cd38e7ceffc79b616d255 by Victor Stinner in 
branch 'master':
bpo-31160: Fix test_builtin for zombie process (#3043)
https://github.com/python/cpython/commit/4baca1b0f7325032598cd38e7ceffc79b616d255


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3079

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3078

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3077

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3074

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:

A reap_children() warning was fixed in test_thread: bpo-31150. It seems like 
the commit 88eee44a91c991dbbdf284fa220e2928b5de105c was not enough to fix all 
warnings.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:

> The GCC job of Travis CI failed with ENV_CHANGED:

Ooops, in fact it was a macOS job:
https://travis-ci.org/python/cpython/jobs/262606830


The GCC job failed with much more errors:
https://travis-ci.org/python/cpython/jobs/262606831

---
0:00:02 load avg: 121.34 [  7/403] test_unittest
Warning -- reap_children() reaped child process 11088
Warning -- reap_children() reaped child process 11089
Warning -- reap_children() reaped child process 11090
Warning -- reap_children() reaped child process 11091

0:14:22 load avg: 136.67 [282/403/1] test_select
Warning -- reap_children() reaped child process 14686

0:16:00 load avg: 110.41 [297/403/1] test_socketserver
Warning -- reap_children() reaped child process 15483
Warning -- reap_children() reaped child process 15492
Warning -- reap_children() reaped child process 15499
Warning -- reap_children() reaped child process 15508

0:18:36 load avg: 105.94 [333/403/1] test_thread
Warning -- reap_children() reaped child process 20670
---

For test_socketserver, see bpo-31151.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

STINNER Victor added the comment:

The GCC job of Travis CI failed with ENV_CHANGED:

Test wait() behavior when waitpid returns WIFSTOPPED; issue29335. ...
Warning -- reap_children() reaped child process 19839
ok

I tested and... WOW! When run in a loop, this test leaks 100 MB per second. It 
creates a lot of processes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31160] Enhance support.reap_children()

[STINNER Victor]

New submission from STINNER Victor:

Attached PR enhances the support.reap_children() function:

* reap_children() now sets environment_altered to True to detect bugs using 
python3 -m test --fail-env-changed
* Replace bare "except:" with "except OSError:" in reap_children()
* Write an unit test for reap_children() using a timeout of 60 seconds

--
messages: 26
nosy: haypo
priority: normal
pull_requests: 3073
severity: normal
status: open
title: Enhance support.reap_children()

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com