[issue31323] test_ssl: reference cycle between ThreadedEchoServer and its ConnectionHandler

2017-09-13 Thread STINNER Victor 

Changes by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31323] test_ssl: reference cycle between ThreadedEchoServer and its ConnectionHandler

2017-09-13 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset 1b00bddd5c4a5728b15eee5a27ed3f78a173ef64 by Victor Stinner (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-31323: Fix reference leak in test_ssl (GH-3263) (#3538)
https://github.com/python/cpython/commit/1b00bddd5c4a5728b15eee5a27ed3f78a173ef64


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31323] test_ssl: reference cycle between ThreadedEchoServer and its ConnectionHandler

2017-09-13 Thread STINNER Victor 

STINNER Victor added the comment:

I don't think that Python 2.7 is affected since Exception has no __traceback__ 
attribute in Python 2.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31323] test_ssl: reference cycle between ThreadedEchoServer and its ConnectionHandler

2017-09-13 Thread Roundup Robot 

Changes by Roundup Robot :


--
keywords: +patch
pull_requests: +3533
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31323] test_ssl: reference cycle between ThreadedEchoServer and its ConnectionHandler

2017-09-01 Thread STINNER Victor 

STINNER Victor added the comment:


New changeset 868710158910fa38e285ce0e6d50026e1d0b2a8c by Victor Stinner in 
branch 'master':
bpo-31323: Fix reference leak in test_ssl (#3263)
https://github.com/python/cpython/commit/868710158910fa38e285ce0e6d50026e1d0b2a8c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31323] test_ssl: reference cycle between ThreadedEchoServer and its ConnectionHandler

2017-09-01 Thread STINNER Victor 

Changes by STINNER Victor :


--
pull_requests: +3306

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31323] test_ssl: reference cycle between ThreadedEchoServer and its ConnectionHandler

2017-09-01 Thread STINNER Victor 

New submission from STINNER Victor:

While testing bpo-31234 fix, I noticed that some test_ssl tests using 
ThreadedEchoServer create reference cycles with ConnectionHandler: 
ConnectionHandler fills ThreadedEchoServer.conn_errors with exceptions, but 
exceptions keep an alive traceback object which contains frame locals.

I tried to use traceback.clear_frames(), but this function is broken: see 
bpo-31321.

Attached PR works around the issue by storing errors are text rather than 
objects.

The PR prevents warnings about dangling threads.

--
components: Tests
messages: 301116
nosy: haypo
priority: normal
severity: normal
status: open
title: test_ssl: reference cycle between ThreadedEchoServer and its 
ConnectionHandler
type: resource usage
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com