[issue31340] Use VS 2017 compiler for build

[Christoph Gohlke]

Christoph Gohlke  added the comment:

> Have you confirmed that's a problem?

No, I have not noticed any problems yet with with Python 3.7.0a3 and many 
extensions built with VS2017.5.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Steve Dower]

Steve Dower  added the comment:

Have you confirmed that's a problem? There are new compatibility promises that 
did not exist for earlier versions of the runtime, but that does not mean there 
are no bugs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Christoph Gohlke]

Christoph Gohlke  added the comment:

Since this has not been reverted/changed for 3.6.4 or 3.7.0a3, another 
potential issue arises: C extensions that are compiled with Visual Studio 2017 
are linked to a newer version of vcruntime140.dll (latest is 14.12.25810, 
VS2017 15.5) than the DLL shipped with the CPython 3.6.4/3.7.0a3 installer 
(14.0.24210, VS2015 Update 3). There is no standard way C extensions that are 
compiled with VS2017 can load the correct/newer vcruntime140.dll. That said, I 
have not noticed any problems yet while testing with Python 3.7.0a3.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Steve Dower]

Steve Dower  added the comment:

No, but if we need to do 3.6.4 quickly for another reason, let me know and I'll 
make this change.

It only affects people who are trying to share intermediate build files (which 
for MSVC purposes, includes static libraries) between their 3.6.2 and 3.6.3 
builds. Full builds are going to be fine, and incremental builds should detect 
the changed tools and be able to rebuild everything. 

So it's solely cases where people are trying to manage the build around 
distutils rather than letting distutils handle it all that are problematic (and 
hey, both of these are terrible options! This is why we're discussing how to 
get people to just stop depending on distutils). I don't think it's worth 
churning the entire ecosystem just for that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Ned Deily]

Ned Deily  added the comment:

If you think we should do a 3.6.4 to address this, we can do that.  I'll leave 
it up to your judgement.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Steve Dower]

Steve Dower  added the comment:

> How about giving priority to VS 2015

That would be the fix, but it's not worth releasing an immediate 3.6.4 IMHO and 
by the time 3.6.4 comes about it could be more pain to change back than to 
leave it. That's the balance I'm thinking about for a while.

Including Ned so he's aware. If we do a snap 3.6.4 for some other reason then 
it's worth swapping the order, but after a few months out there I think the 
damage, small as it is, will have been dealt with.

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Christoph Gohlke]

Christoph Gohlke  added the comment:

I build most of my binaries after calling the correct vcvarsall.bat so I did 
not notice until today, when I was trying to build outside that environment. 

Also, I misread your comment (https://bugs.python.org/issue31340#msg301538) 
earlier and did not worry at that time.

I guess this might become a bigger issue once Appveyor switches to Python 
3.6.3. Projects using Anaconda's prebuilt static libraries for v140 will fail 
to link.

How about giving priority to VS 2015, i.e. "If you have VS 2015 then it will 
use that"?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Steve Dower]

Steve Dower  added the comment:

Build artifacts (static libraries, in this case) are not compatible, but the 
built binaries are.

This may be a reasonable argument for not updating distutils's support in minor 
versions (and I'm totally happy to just stop updating distutils period - see 
the recent distutils-sig discussion for more context). If it had been raised 
before 3.6.3 was released then I'd have switched it back (or at least swapped 
the order, so if v140 was found then it would use that first and fall back on 
v141). Now it's done, I'm not sure whether it hurts more to change it again in 
3.6.4 or not...

The immediate workaround is to set DISTUTILS_USE_SDK and run in a VS 2015 
command prompt, which will bypass all the search logic. Better to rebuild the 
static libraries with v141 as well, but I know that's not trivial or always 
feasible. Alternatively, build with Python 3.6.2 or earlier - until we get the 
ABI stability properly figured out, that's still the best way to ensure 
compatibility with older releases.

I'll give the change back some more thought.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Christoph Gohlke]

Christoph Gohlke  added the comment:

I have Visual Studio 2015 and Visual Studio 2017 Community editions with latest 
patches installed.

Building a minimal C extension on Python 3.6.3 with distutils now uses MSVC 
14.11.25503. That is unexpected.

When building complex extensions that link to static libraries that were built 
with MSVC 14.0, linking fails, e.g. when building Pillow:

'jpeg.lib' was created with an older compiler than other objects; rebuild old 
objects and libraries

It looks like practically v141 is not binary compatible with v140.

--
nosy: +cgohlke

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[INADA Naoki]

INADA Naoki added the comment:

Nice! VS2017 is much lighter than VS2015 for install size!
https://blogs.msdn.microsoft.com/vcblog/2016/08/22/the-lightweight-visual-studio-15-installer/

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Steve Dower]

Steve Dower added the comment:

Note that this should not change anything for 3.6, but enables using VS 2017 to 
build. If you only have VS 2015 then it will use that, and I've enabled 
AppVeyor for both to make sure we keep it that way.

3.7 will also build with either, but there isn't as much importance in 
verifying VS 2015 compatibility.

All of that said, there should be no difference in the built binaries.

--
resolution:  -> fixed
stage: backport needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Steve Dower]

Steve Dower added the comment:


New changeset fd645ec6f5696e841e6d49075f9fd81e54e74d91 by Steve Dower in branch 
'3.6':
[3.6] bpo-31340: Change to building with MSVC v141 (included with Visual Studio 
2017) (GH-3311) (#3386)
https://github.com/python/cpython/commit/fd645ec6f5696e841e6d49075f9fd81e54e74d91


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Steve Dower]

Changes by Steve Dower :


--
stage: needs patch -> backport needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Steve Dower]

Changes by Steve Dower :


--
pull_requests: +3393

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Steve Dower]

Steve Dower added the comment:


New changeset 5fcd5e64eec9ed67613b8fe7356fb8288151ceba by Steve Dower in branch 
'master':
bpo-31340: Change to building with MSVC v141 (included with Visual Studio 2017) 
(#3311)
https://github.com/python/cpython/commit/5fcd5e64eec9ed67613b8fe7356fb8288151ceba


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Steve Dower]

Changes by Steve Dower :


--
pull_requests: +3339

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Jeremy Kloth]

Changes by Jeremy Kloth :


--
nosy: +jkloth

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31340] Use VS 2017 compiler for build

[Steve Dower]

New submission from Steve Dower:

The newer MSVC (v141) is available and reliable, and theoretically binary 
compatible with v140. This means we can update both Python 3.6 and 3.7 to build 
with it.

Testing for this should include:
* pythoncore with v141 and remainder with v140
* Python with v141 and wheels with v140

--
assignee: steve.dower
components: Build, Windows
messages: 301253
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
stage: needs patch
status: open
title: Use VS 2017 compiler for build
type: enhancement
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com