[issue31454] Include "import as" in tutorial

[miss-islington]

miss-islington  added the comment:


New changeset 76349471adfa4366a92438c88fd05a0e1e94c59b by Miss Islington (bot) 
in branch '2.7':
bpo-31454: Include information about "import X as Y" in Modules tutorial 
(GH-4041)
https://github.com/python/cpython/commit/76349471adfa4366a92438c88fd05a0e1e94c59b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[miss-islington]

miss-islington  added the comment:


New changeset e48e6499bbad56f7cc665efa25ae4847f51dbc38 by Miss Islington (bot) 
in branch '3.7':
bpo-31454: Include information about "import X as Y" in Modules tutorial 
(GH-4041)
https://github.com/python/cpython/commit/e48e6499bbad56f7cc665efa25ae4847f51dbc38


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[miss-islington]

miss-islington  added the comment:


New changeset 5a07608d0855e4104e4070328155b52010dec4e7 by Miss Islington (bot) 
in branch '3.6':
bpo-31454: Include information about "import X as Y" in Modules tutorial 
(GH-4041)
https://github.com/python/cpython/commit/5a07608d0855e4104e4070328155b52010dec4e7


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Mariatta Wijaya]

Mariatta Wijaya  added the comment:

Thanks everyone. I've merged Marios's PR. The backport PRs have started and 
will automerge.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[miss-islington]

Change by miss-islington :


--
pull_requests: +5668

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[miss-islington]

Change by miss-islington :


--
pull_requests: +5667

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[miss-islington]

Change by miss-islington :


--
pull_requests: +5666

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Mariatta Wijaya]

Mariatta Wijaya  added the comment:


New changeset fbee88244e8921afdb29fde51a9a010a8ae18277 by Mariatta (Mario 
Corchero) in branch 'master':
bpo-31454: Include information about "import X as Y" in Modules tutorial 
(GH-4041)
https://github.com/python/cpython/commit/fbee88244e8921afdb29fde51a9a010a8ae18277


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Mariatta Wijaya]

Mariatta Wijaya  added the comment:

> PR 4041 looks good to me. Mariatta, do you have time to look at Mario's patch?

Sorry I just saw this now, months later.
Looks good to me. I can merge and backport once the CI passed.
Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Berker Peksag]

Berker Peksag  added the comment:

PR 4041 looks good to me. Mariatta, do you have time to look at Mario's patch?

Sarthak, thank you for your PR, but a PR was opened 12 days before yours 
(sorry, I missed it earlier) Would you like to work on another issue? I've just 
opened bpo-31948 and I'd be happy to review/merge a PR if you have time. Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Berker Peksag]

Berker Peksag  added the comment:

I just reviewed Mario's pull request. Should we mention the "from fibo import 
fib as fibonacci" syntax too?

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +4165

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Mario Corchero]

Change by Mario Corchero :


--
keywords: +patch
pull_requests: +4012
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Mario Corchero]

Change by Mario Corchero :


--
nosy: +mariocj89

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

I might know an aspiring contributor who can work on this. Assigning to myself.

--
assignee: docs@python -> Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Novel]

Novel added the comment:

The offending file is here: 
https://github.com/python/cpython/blob/master/Doc/tutorial/modules.rst

Read the developer's guide to learn how to submit your changes to python. 
https://devguide.python.org/

--
nosy: +nyt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Éric Araujo]

Changes by Éric Araujo :


--
keywords: +easy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[R. David Murray]

R. David Murray added the comment:

Well, this is all volunteer work.  Maybe someone else will feel like doing it :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[Steve Johnson]

Steve Johnson added the comment:

I don't know what a PR is, so I'll let you guys handle it if it is OK with you.

> On Sep 14, 2017, at 11:47 AM, R. David Murray  wrote:
> 
> 
> R. David Murray added the comment:
> 
> I agree that it would seem reasonable to add this to section 6.1 of the 
> tutorial, since it mentions both import statement variants and the modules 
> "global symbol table", which are the two concepts involved in import as.
> 
> Would you like to propose a PR?
> 
> --
> resolution: not a bug -> 
> stage: resolved -> needs patch
> status: closed -> open
> title: Include "import as" in documentation -> Include "import as" in tutorial
> 
> ___
> Python tracker 
> 
> ___

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[R. David Murray]

Changes by R. David Murray :


--
versions: +Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31454] Include "import as" in tutorial

[R. David Murray]

R. David Murray added the comment:

I agree that it would seem reasonable to add this to section 6.1 of the 
tutorial, since it mentions both import statement variants and the modules 
"global symbol table", which are the two concepts involved in import as.

Would you like to propose a PR?

--
resolution: not a bug -> 
stage: resolved -> needs patch
status: closed -> open
title: Include "import as" in documentation -> Include "import as" in tutorial

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com