[issue31482] random.seed() doesn't work with bytes and version=1

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Backport was done. Thanks.

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset c6ce8fba07ea6798eac46ab2808167afecd4d90b by Mariatta (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-31482:  Missing bytes support for random.seed() version 1 (GH-3614) 
(GH-3659)
https://github.com/python/cpython/commit/c6ce8fba07ea6798eac46ab2808167afecd4d90b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ah, now I understand what happened. Thanks Mariatta.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Serhiy, it can't be re-opened since miss-islington deleted the branch already.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

If PR 3629 was closed by mistake it could be just reopened, isn't?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Hi Raymond, 

Somehow the backport PR https://github.com/python/cpython/pull/3629 was closed 
before instead of merged.

To retrigger the backport, we can re-apply the "needs backport to 3.6" label on 
the original PR (3614). I will do this now :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Backport PR has been created. Once the CI checks are done, we can squash and 
merge it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +3648
stage: resolved -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

What is wrong with PR 3629?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Raymond Hettinger]

Raymond Hettinger added the comment:

Mariatta, what is the procedure for completing the backport?  I can see the 
miss-islington bot made a commit but it didn't take in the 3.6 branch.

--
assignee: rhettinger -> Mariatta
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Raymond, why the fix is not backported to 3.6?

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Raymond Hettinger]

Raymond Hettinger added the comment:


New changeset 132a7d7cdbc7cb89fa1c1f4e8192241c3d68f549 by Raymond Hettinger in 
branch 'master':
bpo-31482:  Missing bytes support for random.seed() version 1 (#3614)
https://github.com/python/cpython/commit/132a7d7cdbc7cb89fa1c1f4e8192241c3d68f549


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +3618

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
keywords: +patch
pull_requests: +3605
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31482] random.seed() doesn't work with bytes and version=1

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

The behavior of random.seed() with bytes and version=1 is specially documented. 
But actually it doesn't work.

>>> import random
>>> random.seed(b'abc', version=1)
Traceback (most recent call last):
  File "", line 1, in 
  File "/home/serhiy/py/cpython/Lib/random.py", line 113, in seed
x = ord(a[0]) << 7 if a else 0
TypeError: ord() expected string of length 1, but int found

--
assignee: rhettinger
components: Library (Lib)
messages: 302246
nosy: rhettinger, serhiy.storchaka
priority: normal
severity: normal
status: open
title: random.seed() doesn't work with bytes and version=1
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com