[issue31569] inconsistent case of PCbuild/ directory

[Steve Dower]

Changes by Steve Dower :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31569] inconsistent case of PCbuild/ directory

[Paul Moore]

Paul Moore added the comment:


New changeset f1502d097c29b266a5748312ee2451a2d6ac0af6 by Paul Moore (Stefan 
Grönke) in branch 'master':
bpo-31569: correct PCBuild/ case to PCbuild/ in build scripts and docs (GH-3711)
https://github.com/python/cpython/commit/f1502d097c29b266a5748312ee2451a2d6ac0af6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31569] inconsistent case of PCbuild/ directory

[Paul Moore]

Paul Moore added the comment:

OK, having re-read the PR, I'm fine with applying it as is, too.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31569] inconsistent case of PCbuild/ directory

[Zachary Ware]

Zachary Ware added the comment:

Personally, *I'd* prefer PC -> Windows and PCbuild -> Windows\build :)

I'm also good with the PR as is.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31569] inconsistent case of PCbuild/ directory

[Steve Dower]

Steve Dower added the comment:

I'm okay with the PR as it stands, especially the parts that affect GitHub and 
appveyor, as those are almost certainly using case sensitive comparisons.

It's definitely not easier to update the case of a file that is in git, and 
doing so will very likely break users (we had to do a case-folding pass over 
the Mercurial repository because while it could handle case changes, git could 
not import the ones we had in history).

Personally I'd prefer it to have always been PCBuild rather than PCbuild, and 
it's very likely that I've introduced most of the 'incorrect' ones. But what's 
done is done and we should avoid the potential distraction of mismatched case 
throughout the rest of our codebase.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31569] inconsistent case of PCbuild/ directory

[Paul Moore]

Paul Moore added the comment:

I would strongly prefer the docs to be changed to match the implementation 
rather than the other way round. However, I don't see the use case for this - 
what case sensitive filesystem would anybody be building the Windows version of 
Python on?


I'm -1 on changing the actual build scripts, as that introduces risk for no 
actual benefit. I'm +0 on changing the docs, assuming it's possible to make 
things consistent with a doc-only change. But I can't imagine anyone reading 
those docs would expect a filesystem to be case sensitive, so I doubt it would 
matter in practice.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31569] inconsistent case of PCbuild/ directory

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Wouldn't be easier to make changes in the opposite direction? Change PCbuild to 
PCBuild?

The file systems on Windows are case-insensitive, so this hardly an error.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31569] inconsistent case of PCbuild/ directory

[Stefan Grönke]

New submission from Stefan Grönke:

While reading the build documentation for Windows, I've noticed the `PCbuild/` 
directory to be mentioned with a different case than the directory in the 
repository (`PCBuild/` instead of `PCbuild/`).

Every occasion of `PCBuild` should be replaced with `PCbuild`, so that builds 
can work on case-sensitive filesystems as well.

--
assignee: docs@python
components: Build, Documentation, Windows
messages: 302851
nosy: docs@python, gronke, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
pull_requests: 3704
severity: normal
status: open
title: inconsistent case of PCbuild/ directory
type: enhancement
versions: Python 2.7, Python 3.3, Python 3.4, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com