[issue31721] assertion failure in FutureObj_finalize() after setting _log_traceback to True

2017-12-25 Thread Yury Selivanov 

Change by Yury Selivanov :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31721] assertion failure in FutureObj_finalize() after setting _log_traceback to True

2017-12-25 Thread Yury Selivanov 

Yury Selivanov  added the comment:


New changeset e0aef4f3cd339a405d2a7fbd35a50afa64834f84 by Yury Selivanov in 
branch 'master':
bpo-31721: Allow Future._log_traceback to only be set to False (#5009)
https://github.com/python/cpython/commit/e0aef4f3cd339a405d2a7fbd35a50afa64834f84


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31721] assertion failure in FutureObj_finalize() after setting _log_traceback to True

2017-12-25 Thread Yury Selivanov 

Change by Yury Selivanov :


--
resolution: wont fix -> 
stage: resolved -> patch review
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31721] assertion failure in FutureObj_finalize() after setting _log_traceback to True

2017-12-25 Thread Yury Selivanov 

Change by Yury Selivanov :


--
pull_requests: +4898

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31721] assertion failure in FutureObj_finalize() after setting _log_traceback to True

2017-12-25 Thread Yury Selivanov 

Yury Selivanov  added the comment:

> _log_traceback is a private property and asyncio implementation detail, you 
> should never touch it.

But still, we shouldn't let Python crash if someone sets it.  I'll make a PR to 
fix this the way Oren proposed.

Andrew, let's discuss later with what we want to replace _log_traceback. I 
don't like that it's a semi-public thing.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31721] assertion failure in FutureObj_finalize() after setting _log_traceback to True

2017-12-25 Thread Andrew Svetlov 

Andrew Svetlov  added the comment:

_log_traceback is a private property and asyncio implementation detail, you 
should never touch it.

--
nosy: +asvetlov
resolution:  -> wont fix
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31721] assertion failure in FutureObj_finalize() after setting _log_traceback to True

2017-10-07 Thread Oren Milman 

New submission from Oren Milman :

The following code causes an assertion failure in FutureObj_finalize() (in
Modules/_asynciomodule.c):

import asyncio
asyncio.Future()._log_traceback = True


Maybe we should allow Python code to only set it to False, and raise a
ValueError in case Python code tries to set it to True?

(PR 2050 made _log_traceback writable. Are there any usecases for setting it to
True from Python code?)

--
components: asyncio
messages: 303878
nosy: Oren Milman, yselivanov
priority: normal
severity: normal
status: open
title: assertion failure in FutureObj_finalize() after setting _log_traceback 
to True
type: crash
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com