[issue31734] crash or SystemError in sqlite3.Cache in case it is uninitialized or partially initialized

[Berker Peksag]

Change by Berker Peksag :


--
resolution:  -> wont fix
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31734] crash or SystemError in sqlite3.Cache in case it is uninitialized or partially initialized

[Berker Peksag]

Berker Peksag  added the comment:

Thanks for the PR and for the work you've been doing to fix similar bugs in 
Python!

The Cache class is an implementation detail and it has no practical use for 
third party users. See issue 30262 for a discussion on making it private.

If a user somehow finds the Cache class, wants to do something with it, it's 
their problem if it crashes the interpreter.

So, unless you can demonstrate that these problems can be reproduced without 
using the Cache class directly, I'm inclined to close this issue as 'wontfix'.

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31734] crash or SystemError in sqlite3.Cache in case it is uninitialized or partially initialized

[Oren Milman]

Change by Oren Milman :


--
keywords: +patch
pull_requests: +3912
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31734] crash or SystemError in sqlite3.Cache in case it is uninitialized or partially initialized

[Eric N. Vander Weele]

Change by Eric N. Vander Weele :


--
nosy: +ericvw

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31734] crash or SystemError in sqlite3.Cache in case it is uninitialized or partially initialized

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +ghaering, serhiy.storchaka
versions: +Python 2.7, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31734] crash or SystemError in sqlite3.Cache in case it is uninitialized or partially initialized

[Oren Milman]

Oren Milman  added the comment:

Also, the following code results in a memory leak:
import sqlite3
cache = sqlite3.Cache.__new__(sqlite3.Cache)

This is because pysqlite_cache_dealloc() just returns in case of an 
uninitialized
Cache object.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31734] crash or SystemError in sqlite3.Cache in case it is uninitialized or partially initialized

[Oren Milman]

New submission from Oren Milman :

The following code causes a crash:
import sqlite3
cache = sqlite3.Cache.__new__(sqlite3.Cache)
cache.get(None)

This is because pysqlite_cache_get() (in Modules/_sqlite/cache.c) assumes that
the Cache object is initialized, and so it passes self->mapping to
PyDict_GetItem(), which assumes it is not NULL, and crashes.


Also, the following code causes a SystemError ('null argument to internal
routine'), as well as refleaks in the deallocation of the Cache object:
import sqlite3
cache = sqlite3.Cache(str)
try:
cache.__init__()
except TypeError:
pass
cache.get(None)

This is because pysqlite_cache_init() first sets self->factory to NULL, and
only then parses its arguments, so in case it fails to parse the arguments
(e.g. due to a wrong number of arguments) we are left with a partially
initialized Cache object.


While we are here, we should also fix refleaks that occur when
sqlite3.Cache.__init__() is called more than once.

--
components: Extension Modules
messages: 303958
nosy: Oren Milman
priority: normal
severity: normal
status: open
title: crash or SystemError in sqlite3.Cache in case it is uninitialized or 
partially initialized
type: crash
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com