[issue3180] Interrupts are lost during readline PyOS_InputHook processing

[Mark Lawrence]

Mark Lawrence  added the comment:

I'm unsure as to whether this is a feature request or a behaviour problem, 
anyone?  Regardless could a core dev take a look at the patch which involves 
changes to the API for PyOS_InputHook, see msg68638.

--
nosy: +BreamoreBoy
stage: unit test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3180] Interrupts are lost during readline PyOS_InputHook processing

[Michael Abbott]

New submission from Michael Abbott <[EMAIL PROTECTED]>:

The (undocumented!) API for PyOS_InputHook has two defects which are
addressed in the attached patch (at least when using the readline
module): firstly the called hook currently has to guess that input will
come on descriptor 0; secondly, any Ctrl-C interrupts encountered during
the processing of the input hook are lost.

This loss of interrupts can be rather annoying.  The attached patch
addresses these problems by redefining the API to PyOS_InputHook as 

int PyOS_InputHook(int file_in);

where file_in is the descriptor to monitor (PyOS_InputHook need not
return until file_in is ready to read), and the return value is non-zero
if and only if processing was interrupted.

Testing for interruption is implemented in the HAVE_RL_CALLBACK and
HAVE_SELECT branch of Modules/readline.c; other uses retain their
original functionality (I believe!).

The attached patch was prepared against
http://svn.python.org/projects/python/trunk , current at the time of
writing.

--
components: None
files: input-hook.patch
keywords: patch
messages: 68638
nosy: Araneidae
severity: normal
status: open
title: Interrupts are lost during readline PyOS_InputHook processing
type: feature request
versions: Python 2.6
Added file: http://bugs.python.org/file10709/input-hook.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3180] Interrupts are lost during readline PyOS_InputHook processing

[Daniel Diniz]

Daniel Diniz  added the comment:

Michael,
How does this interact with the fix from issue 706406?

--
components: +Extension Modules -None
nosy: +ajaksu2
priority:  -> normal
stage:  -> test needed
versions: +Python 2.7, Python 3.2 -Python 2.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3180] Interrupts are lost during readline PyOS_InputHook processing

[STINNER Victor]

STINNER Victor added the comment:

I don't understand how to reproduce the issue, there is no unit test nor a 
description how to reproduce the issue.

I'm not aware of a bug where CTRL+c is simply ignored. CTRL+c is now well 
handled in Python 2.7, on Linux and Windows at least.

Since the bug is now 7 years old, I just close it as out of date, sorry.

--
nosy: +haypo
resolution:  -> out of date
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3180] Interrupts are lost during readline PyOS_InputHook processing

[Michiel de Hoon]

Michiel de Hoon added the comment:

As it happens, we just ran into the same bug.
To reproduce this issue, run

>>> from Tkinter import *
>>> Tk()

Then Ctrl-C will not generate a KeyboardInterrupt.

At first glance, the solution suggested by the original poster seems good. Can 
this issue by reopened? I'd be happy to take over this issue report and check 
the patch in more detail.

--
nosy: +Michiel.de.Hoon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3180] Interrupts are lost during readline PyOS_InputHook processing

[STINNER Victor]

STINNER Victor added the comment:

This issue is now closed. Please open a new issue. You should mention
your OS and the Python version at least.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3180] Interrupts are lost during readline PyOS_InputHook processing

[Michiel de Hoon]

Michiel de Hoon added the comment:

I have opened a new issue 23237 for this bug; please see
http://bugs.python.org/issue23237

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3180] Interrupts are lost during readline PyOS_InputHook processing

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com