[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Martin Panter]

Martin Panter  added the comment:

The only problem with the 3.7+ documentation is the note about 3.2. Several 
paragraphs under 
,
 it still says

“Changed in version 3.2: The default for ‘close_fds’ was changed from False to 
what is described above.”

However the description it refers to was removed in 3.6. IMO it would make 
sense to add the description to the note:

“Changed in version 3.2: The default for ‘close_fds’ was changed from False to 
True on Unix. On Windows the default was changed from False to True when 
stdin/stdout/stderr are None.”

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Gregory P. Smith]

Gregory P. Smith  added the comment:

Only if someone can point to a concrete problem to be fixed in the 3.7+ docs.  
Looking at all references to close_fds in 
https://docs.python.org/3/library/subprocess.html I don't see one.

(I'm not going to touch the 3.6 docs)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Tal Einat]

Tal Einat  added the comment:

Gregory, this issue was about the docs, not the doc-string (help()). Are you 
sure it should be closed?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Gregory P. Smith]

Gregory P. Smith  added the comment:

In 3.6 this help(subprocess.Popen.__init__) is accurate and encourages looking 
at the docs.  In 3.7 and later it'll simply report close_fds=True in the 
siguature as that is the case in 3.7 onwards.

I see nothing to fix here.

--
nosy: +gregory.p.smith
resolution:  -> wont fix
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Gregory P. Smith]

Change by Gregory P. Smith :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Danish Prakash]

Change by Danish Prakash :


--
keywords: +patch
pull_requests: +10276
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Tal Einat]

Tal Einat  added the comment:

Danish, see Martin's previous comment (msg314413):

"... the signature at [the 3.6 docs] should not show close_fds=True, because 
that is not necessarily the default on Windows."

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Danish Prakash]

Danish Prakash  added the comment:

I'd like to work on this.

I get that the 3.7+ doc still has the irrelevant change from 3.6 which needs to 
be removed but I'm not sure what's wrong with the 3.6 doc.

> The signature is indeed awkward for 3.6,

--
nosy: +danishprakash

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Tal Einat]

Tal Einat  added the comment:

ISTM that the docs need to be fixed for both 3.7+ and for 3.6.

The signature is indeed awkward for 3.6, but it's too minor a detail to address 
considering it's no longer relevant for 3.7 and later.

--
assignee:  -> docs@python
components: +Documentation -Library (Lib)
keywords: +easy
nosy: +docs@python, taleinat
versions: +Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Martin Panter]

Martin Panter  added the comment:

The close_fds= in that signature seems fine to me. If you read 
the documentation, it says the default mode depends on the platform, and on 
other parameters. However I think the signature at 

 should not show close_fds=True, because that is not necessarily the default on 
Windows.

It seems the default on Windows was changed to always True in 3.7, making it 
consistent across platforms and other parameters, thanks to Issue 19764. But 
the 3.7 documentation is quirky. “Changed in version 3.2: The default for 
‘close_fds’ was changed from False to what is described above” refers to the 
3.7 default when it was meant to refer to the 3.2–3.6 default.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Алексей Аверченко]

New submission from Алексей Аверченко :

[11:30:03 ~]$ python
Python 3.6.1 |Anaconda 4.4.0 (x86_64)| (default, May 11 2017, 13:04:09)
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import subprocess
>>> help(subprocess.Popen.__init__)
Help on function __init__ in module subprocess:

__init__(self, args, bufsize=-1, executable=None, stdin=None, stdout=None, 
stderr=None, preexec_fn=None, close_fds=, 
shell=False, cwd=None, env=None, universal_newlines=False, startupinfo=None, 
creationflags=0, restore_signals=True, start_new_session=False, pass_fds=(), *, 
encoding=None, errors=None)
Create new Popen instance.

--
components: Library (Lib)
messages: 304642
nosy: Алексей Аверченко
priority: normal
severity: normal
status: open
title: Opaque default value for close_fds argument in Popen.__init__
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com