[issue31933] some Blake2 parameters are encoded backwards on big-endian platforms

[Christian Heimes]

Change by Christian Heimes :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31933] some Blake2 parameters are encoded backwards on big-endian platforms

[Christian Heimes]

Christian Heimes  added the comment:


New changeset a512493371a073e252a2e52b445aa2d66ddca7cb by Christian Heimes 
(Miss Islington (bot)) in branch '3.6':
bpo-31933: fix blake2 multi-byte params on big endian platforms (GH-4250) 
(#4262)
https://github.com/python/cpython/commit/a512493371a073e252a2e52b445aa2d66ddca7cb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31933] some Blake2 parameters are encoded backwards on big-endian platforms

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +4224

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31933] some Blake2 parameters are encoded backwards on big-endian platforms

[Christian Heimes]

Christian Heimes  added the comment:


New changeset dcfb0e3c04f1b29a0d09bb0a81dcd5ee5a5fef1a by Christian Heimes 
(Jack O'Connor) in branch 'master':
bpo-31933: fix blake2 multi-byte params on big endian platforms (#4250)
https://github.com/python/cpython/commit/dcfb0e3c04f1b29a0d09bb0a81dcd5ee5a5fef1a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31933] some Blake2 parameters are encoded backwards on big-endian platforms

[Christian Heimes]

Christian Heimes  added the comment:

Good work, thanks for your PR!

--
assignee:  -> christian.heimes
components: +Extension Modules
nosy: +christian.heimes
versions:  -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31933] some Blake2 parameters are encoded backwards on big-endian platforms

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
pull_requests: +4211
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31933] some Blake2 parameters are encoded backwards on big-endian platforms

[Jack O'Connor]

New submission from Jack O'Connor :

See https://github.com/BLAKE2/libb2/issues/12.

All Blake2 params have to be encoded in little-endian byte order. For the two 
multi-byte integer params, leaf_length and node_offset, that means that 
assigning a native-endian integer to them appears to work on little-endian 
platforms, but gives the wrong result on big-endian. The current libb2 API 
doesn't make that very clear, and @sneves is working on new API functions in 
the GH issue above. In the meantime, we can work around the problem by 
explicitly assigning little-endian values to the parameter block.

--
messages: 305473
nosy: oconnor663
priority: normal
severity: normal
status: open
title: some Blake2 parameters are encoded backwards on big-endian platforms
type: behavior
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com