[issue32046] 2to3 fix for operator.isCallable()

2018-08-02 Thread Berker Peksag 


Berker Peksag  added the comment:

> I suppose stable branches should be left alone?

We do backport lib2to3 PRs to maintenance branches, but since this is already 
in 3.7 and 3.6 is four months away from being in security-fix-only mode, I 
think we can close this as 'fixed' now.

--
nosy: +berker.peksag
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32046] 2to3 fix for operator.isCallable()

2018-07-13 Thread Guido van Rossum 


Change by Guido van Rossum :


--
nosy:  -gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32046] 2to3 fix for operator.isCallable()

2018-07-13 Thread Dong-hee Na 


Dong-hee Na  added the comment:

@serhiy.storchaka
If we don't have plans with backporting patches than we can close this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32046] 2to3 fix for operator.isCallable()

2017-11-28 Thread Éric Araujo 

Éric Araujo  added the comment:

Merged in master, I suppose stable branches should be left alone?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32046] 2to3 fix for operator.isCallable()

2017-11-28 Thread Éric Araujo 

Éric Araujo  added the comment:


New changeset a489599793f9b00ddc2c68e2ce3bce9cbb2c09a2 by Éric Araujo (Dong-hee 
Na) in branch 'master':
bpo-32046: Update 2to3 when converts operator.isCallable(obj). (#4417)
https://github.com/python/cpython/commit/a489599793f9b00ddc2c68e2ce3bce9cbb2c09a2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32046] 2to3 fix for operator.isCallable()

2017-11-17 Thread Guido van Rossum 

Guido van Rossum  added the comment:

I would convert this to `callable()` -- the conversion to 
collections.abc.Callable is more verbose and requires an extra import (that can 
be slow).

--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32046] 2to3 fix for operator.isCallable()

2017-11-16 Thread Éric Araujo 

Change by Éric Araujo :


--
Removed message: https://bugs.python.org/msg306393

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32046] 2to3 fix for operator.isCallable()

2017-11-16 Thread Éric Araujo 

Éric Araujo  added the comment:

Why about just removing the check, now that callable has been back in 3.x for a 
few releases?

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32046] 2to3 fix for operator.isCallable()

2017-11-16 Thread Dong-hee Na 

Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32046] 2to3 fix for operator.isCallable()

2017-11-16 Thread Dong-hee Na 

Change by Dong-hee Na :


--
keywords: +patch
pull_requests: +4366
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32046] 2to3 fix for operator.isCallable()

2017-11-16 Thread Serhiy Storchaka 

New submission from Serhiy Storchaka :

Currently 2to3 converts `operator.isCallable(obj)` to `hasattr(obj, 
'__call__')`. This looks cumbersome, and can be deceived by instance attribute 
__call__. The more correct way is to use `isinstance(obj, 
collections.abc.Callable)`. Starting from Python 3.2 it can use the callable() 
builtin.

--
components: 2to3 (2.x to 3.x conversion tool)
messages: 306346
nosy: benjamin.peterson, levkivskyi, serhiy.storchaka
priority: normal
severity: normal
status: open
title: 2to3 fix for operator.isCallable()
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com