[issue32144] email.policy.SMTP and SMTPUTF8 doesn't honor linesep's value

[R. David Murray]

R. David Murray  added the comment:

A note would be too heavy handed.  And get_content is a different function from 
get_payload, so there is no change in behavior, there is a new API with a more 
consistent behavior.  Basically, Python programs in general use \n line endings 
internally, and email was an exception to that rule (and is no longer, in the 
new API).  (There's a now closed issue about this somewhere in the tracker.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32144] email.policy.SMTP and SMTPUTF8 doesn't honor linesep's value

[Abhilash Raj]

Abhilash Raj  added the comment:

Well, I myself missed the "serialization" part, so it probably was my mistake. 
Maybe a :note: saying line endings are only added in serialized outputs like 
the one obtained from `as_string()` or `as_bytes()` but not for other methods 
that return the body like `get_content()` or `get_payload()` might be helpful.

I stumbled upon it while porting some code from Python 2 to Python 3 and 
decided to use the new API. But, given the behavior of Python 2's 
get_content(decode=True), I would say it might just be clearer if docs 
mentioned this change in behavior (even though the new one is the "correct" 
one).

I can send in a pull request with modifications if you'd like.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32144] email.policy.SMTP and SMTPUTF8 doesn't honor linesep's value

[R. David Murray]

R. David Murray  added the comment:

OK, I should have used the term the docs actually use: "serialization".  
get_content() is, I hope, clearly not serialization, while as_string() is.  
Does that make it make more sense?  Do you see a way to improve the docs in 
this regard?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32144] email.policy.SMTP and SMTPUTF8 doesn't honor linesep's value

[Abhilash Raj]

Abhilash Raj  added the comment:

I understand that the line endings are meant for "outputs", but what 
constitutes as output in this case?

I now see that `EmailMessage.as_string()` gives me `\r\n` as line endings and, 
which is probably what you mean by output and `get_content()` given me internal 
representation of the Email's content?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32144] email.policy.SMTP and SMTPUTF8 doesn't honor linesep's value

[R. David Murray]

R. David Murray  added the comment:

Your are reading the documentation wrong.  For linesep, it says "The string to 
be used to terminate lines in serialized output."  The key word there is 
"output".  email operates in "universal newline mode" when parsing messages, 
turning all line endings into python's internal \n format.  What the linesep 
policy controls is the *output* line separator.

Note that the python2 behavior for decode=True is arguably a bug, but not one 
we are going to fix for backward compatibility reasons.

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32144] email.policy.SMTP and SMTPUTF8 doesn't honor linesep's value

[Mark Sapiro]

Change by Mark Sapiro :


--
nosy: +msapiro

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32144] email.policy.SMTP and SMTPUTF8 doesn't honor linesep's value

[Abhilash Raj]

New submission from Abhilash Raj :

According to the documentation, email.policy.SMTP and .SMTPUTF8  should have 
CRLF (`\r\n`) as line endings for text/plain parts.

However, a new message parsed using message_from_binary_file with 
policy.SMTPUTF8 has `\n` as line endings for text/plain parts. This happens 
when I use get_content() on the new EmailMessage API.

Just to mention, in Python 2.7, the old `get_payload(decode=True)` returns the 
body with CRLF as line endings. However, in Python 3, `get_payload()` also 
returns '\n' as line endings.

Am I reading the documentation wrong?

--
components: email
messages: 307029
nosy: barry, maxking, r.david.murray
priority: normal
severity: normal
status: open
title: email.policy.SMTP and SMTPUTF8 doesn't honor linesep's value
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com