[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

2017-11-30 Thread STINNER Victor

STINNER Victor  added the comment:

> Thank you Andrew! This have made the code cleaner.

Yeah! I really love to see old these old crappy legacy stuff to go away. The 
asyncio code behave shorter, simpler and with less "#ifdef" ;-)

I understand that the Python language and stdlib became better the last 2-3 
years ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

2017-11-30 Thread Andrew Svetlov

Andrew Svetlov  added the comment:

You are welcome!
Thanks for review

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

2017-11-30 Thread Serhiy Storchaka

Serhiy Storchaka  added the comment:

Thank you Andrew! This have made the code cleaner.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

2017-11-30 Thread Andrew Svetlov

Change by Andrew Svetlov :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

2017-11-29 Thread Andrew Svetlov

Andrew Svetlov  added the comment:


New changeset cc83920ad267c992bc421987829da04d88ae816b by Andrew Svetlov in 
branch 'master':
bpo-32166: Drop Python 3.4 code from asyncio (#4612)
https://github.com/python/cpython/commit/cc83920ad267c992bc421987829da04d88ae816b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

2017-11-29 Thread Andrew Svetlov

Andrew Svetlov  added the comment:

Fixed unix_events.py but see no legacy code in futures.py and sslproto.py.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

2017-11-29 Thread Andrew Svetlov

Change by Andrew Svetlov :


--
Removed message: https://bugs.python.org/msg307226

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32166] Drop python 3.4 code from asyncio.coroutines and asyncio.unix_events

2017-11-29 Thread Andrew Svetlov

Andrew Svetlov  added the comment:

Ok, will do everything in single PR

--
title: Drop python 3.4 code from asyncio.coroutines -> Drop python 3.4 code 
from asyncio.coroutines and asyncio.unix_events

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com