[issue32260] siphash shouldn't byte swap the keys

2017-12-09 Thread Benjamin Peterson 

Change by Benjamin Peterson :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32260] siphash shouldn't byte swap the keys

2017-12-09 Thread Benjamin Peterson 

Benjamin Peterson  added the comment:


New changeset 60ed1308304964e5648d8bfc9b74bd549570fa83 by Benjamin Peterson in 
branch 'master':
byte swap the raw hash secrets (more bpo-32260) (#4773)
https://github.com/python/cpython/commit/60ed1308304964e5648d8bfc9b74bd549570fa83


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32260] siphash shouldn't byte swap the keys

2017-12-09 Thread Benjamin Peterson 

Change by Benjamin Peterson :


--
pull_requests: +4675

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32260] siphash shouldn't byte swap the keys

2017-12-09 Thread Benjamin Peterson 

Benjamin Peterson  added the comment:


New changeset 4e3e156391e70cd23cae18f2629ec323b3b1e7de by Benjamin Peterson in 
branch 'master':
bpo-32260: don't byte swap siphash keys (#4771)
https://github.com/python/cpython/commit/4e3e156391e70cd23cae18f2629ec323b3b1e7de


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32260] siphash shouldn't byte swap the keys

2017-12-09 Thread Benjamin Peterson 

Change by Benjamin Peterson :


--
keywords: +patch
pull_requests: +4674
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32260] siphash shouldn't byte swap the keys

2017-12-09 Thread Benjamin Peterson 

New submission from Benjamin Peterson :

Reference siphash takes the keys as a bytes, so it makes sense to byte swap 
when reifying the keys as 64-bit integers. However, Python's modified siphash 
takes host integers in to start with.

--
components: Interpreter Core
messages: 307910
nosy: benjamin.peterson
priority: normal
severity: normal
status: open
title: siphash shouldn't byte swap the keys
type: behavior
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com