[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Steve Dower]

Steve Dower  added the comment:

This appears to be completely resolved now, but if it's not, please ping with 
the details and we'll reopen.

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Lorenz Mende]

Change by Lorenz Mende :


--
pull_requests: +12669

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Vinay Sajip]

Vinay Sajip  added the comment:

See also bpo-35558.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Steve Dower]

Steve Dower  added the comment:

That error is a bug in the test, but it only shows up on an error path anyway. 
Without removing the extra None we don't get to see the actual error output.

I can't look into this over the next week or two, but a quick glance at the 
original PR looks like a lot of quotes are missing around executable paths, so 
maybe it was that?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[STINNER Victor]

STINNER Victor  added the comment:

Pablo Galindo reverted the change because it broke Windows buildbots, and we 
have a policy to revert a change breaking buildbots if the regression cannot be 
fixed "quickly" event:
https://pythondev.readthedocs.io/ci.html#revert-on-fail

Is someone working on investigating the bug? Do you need help to reproduce the 
bug?

Copy of the test_venv error:

==
ERROR: test_unicode_in_batch_file (test.test_venv.BasicTest)
--
Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows8\build\lib\test\test_venv.py", line 302, 
in test_unicode_in_batch_file
out, err = check_output(
  File "D:\buildarea\3.x.bolen-windows8\build\lib\test\test_venv.py", line 37, 
in check_output
raise subprocess.CalledProcessError(
TypeError: __init__() takes from 3 to 5 positional arguments but 6 were given

https://buildbot.python.org/all/#/builders/32/builds/1707

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[miss-islington]

miss-islington  added the comment:


New changeset 3ba5e253de1a52e9692aa645c95072705f08b7bb by Miss Islington (bot) 
in branch '3.7':
Revert "bpo-32409: Fix regression in activate.bat on international Windows 
(GH-10295)" (GH-10403)
https://github.com/python/cpython/commit/3ba5e253de1a52e9692aa645c95072705f08b7bb


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 6843ffe4533e9f2cde036296fd932fef6f059687 by Pablo Galindo in 
branch 'master':
Revert "bpo-32409: Fix regression in activate.bat on international Windows 
(GH-10295)" (GH-10403)
https://github.com/python/cpython/commit/6843ffe4533e9f2cde036296fd932fef6f059687


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[miss-islington]

Change by miss-islington :


--
pull_requests: +9689

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +9688
stage: resolved -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Martin Bijl-Schwab]

Martin Bijl-Schwab  added the comment:

I will have a look.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

This commit broke a lot of the Windows buildbots:

https://buildbot.python.org/all/#/builders/32/builds/1707
https://buildbot.python.org/all/#/builders/113/builds/733
https://buildbot.python.org/all/#/builders/40/builds/1137
https://buildbot.python.org/all/#/builders/130/builds/420
https://buildbot.python.org/all/#/builders/3/builds/1634

Can someone work on a patch soon? If not we need to revert the commits in all 
the branches that are failed to build :(

--
nosy: +pablogsal
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Vinay Sajip]

Vinay Sajip  added the comment:


New changeset 881e273c795f2f5154b8afebfa299f0e830f3712 by Vinay Sajip (Miss 
Islington (bot)) in branch '3.7':
bpo-32409: Fix regression in activate.bat on international Windows (GH-10295) 
(GH-10377)
https://github.com/python/cpython/commit/881e273c795f2f5154b8afebfa299f0e830f3712


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[miss-islington]

Change by miss-islington :


--
pull_requests: +9679

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Vinay Sajip]

Vinay Sajip  added the comment:


New changeset c64583b6d3e8516a8cd2b5f84fc1e300bfac2206 by Vinay Sajip 
(samstagern) in branch 'master':
bpo-32409: Fix regression in activate.bat on international Windows (GH-10295)
https://github.com/python/cpython/commit/c64583b6d3e8516a8cd2b5f84fc1e300bfac2206


--
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Martin Bijl-Schwab]

Martin Bijl-Schwab  added the comment:

I meant https://bugs.python.org/issue35148

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Martin Bijl-Schwab]

Martin Bijl-Schwab  added the comment:

it does not work as expected on swiss german (and likely other 
internationalised) windows systems. See https://bugs.python.org/issue32409

--
nosy: +Martin Bijl-Schwab

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +9604

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Steve Dower]

Steve Dower  added the comment:


New changeset 8e149ff481acbb3889c825b8bf7b10aa191f09a7 by Steve Dower (Miss 
Islington (bot)) in branch '3.6':
bpo-32409: Ensures activate.bat can handle Unicode contents (GH-5766)
https://github.com/python/cpython/commit/8e149ff481acbb3889c825b8bf7b10aa191f09a7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Steve Dower]

Change by Steve Dower :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Steve Dower]

Steve Dower  added the comment:


New changeset a3d6c1b23b8a49b5003fdbd115d3598fe3d4c4bf by Steve Dower (Miss 
Islington (bot)) in branch '3.7':
bpo-32409: Ensures activate.bat can handle Unicode contents (GH-5765)
https://github.com/python/cpython/commit/a3d6c1b23b8a49b5003fdbd115d3598fe3d4c4bf


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[miss-islington]

Change by miss-islington :


--
pull_requests: +5545

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[miss-islington]

Change by miss-islington :


--
pull_requests: +5543, 5544

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[miss-islington]

Change by miss-islington :


--
pull_requests: +5543

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Steve Dower]

Steve Dower  added the comment:


New changeset 6240917b773b52f8883387b9e3a5f327a4372068 by Steve Dower in branch 
'master':
bpo-32409: Ensures activate.bat can handle Unicode contents (GH-5757)
https://github.com/python/cpython/commit/6240917b773b52f8883387b9e3a5f327a4372068


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Steve Dower]

Change by Steve Dower :


--
keywords: +patch
pull_requests: +5535
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Steve Dower]

Steve Dower  added the comment:

Eryk's solution seems to be best, so I'll add that.

--
assignee:  -> steve.dower
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

[Eryk Sun]

Eryk Sun  added the comment:

The CMD shell decodes batch scripts using the attached console's output 
codepage, which defaults to OEM. OTOH, venv writes the replacement values for 
the template activate.bat as UTF-8 (codepage 65001), which is correct and 
should not be downgraded to OEM. 

Instead, the batch script could temporarily switch the console to codepage 
65001. Then restore the previous codepage at the end. For example:

@echo off
for /f "tokens=2 delims=:" %%a in ('"%SystemRoot%\System32\chcp.com"') do (
set "CODEPAGE=%%a"
)
"%SystemRoot%\System32\chcp.com" 65001 > nul

[rest of script]

"%SystemRoot%\System32\chcp.com" %CODEPAGE% > nul
set "CODEPAGE="
:END

--
components: +Library (Lib), Unicode, Windows -Extension Modules
nosy: +eryksun, ezio.melotti, paul.moore, steve.dower, tim.golden, vstinner, 
zach.ware
stage:  -> needs patch
title: venv activation doesn't work, if project is in a Windows folder that has 
latin-1 supplement characters (such as ä,ö,å) in its path -> venv activate.bat 
is UTF-8 encoded but uses current console codepage
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com