[issue32506] dataclasses: no need for OrderedDict now that dict guarantees to keep insertion order

[Eric V. Smith]

Change by Eric V. Smith :


--
dependencies:  -Dict order is now guaranteed, so add tests and doc for it
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32506] dataclasses: no need for OrderedDict now that dict guarantees to keep insertion order

[Eric V. Smith]

Eric V. Smith  added the comment:


New changeset d13889214a4c81b78fa8683d35bdbd17ff22f4fe by Eric V. Smith in 
branch 'master':
bpo-32506: Change dataclasses from OrderedDict to plain dict. (gh-5131)
https://github.com/python/cpython/commit/d13889214a4c81b78fa8683d35bdbd17ff22f4fe


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32506] dataclasses: no need for OrderedDict now that dict guarantees to keep insertion order

[Eric V. Smith]

Change by Eric V. Smith :


--
pull_requests: +4992

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32506] dataclasses: no need for OrderedDict now that dict guarantees to keep insertion order

[Eric V. Smith]

Change by Eric V. Smith :


--
keywords: +patch
pull_requests: +4991
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32506] dataclasses: no need for OrderedDict now that dict guarantees to keep insertion order

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
components: +Library (Lib)
dependencies: +Dict order is now guaranteed, so add tests and doc for it

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32506] dataclasses: no need for OrderedDict now that dict guarantees to keep insertion order

[Eric V. Smith]

New submission from Eric V. Smith :

There are several places where OrderedDict escapes from dataclasses. Switching 
to dict means we don't have to use OrderedDict forever.

For the 3.6 backport, I'm also going to use dict. I saw an analysis (from 
Raymond, maybe?) that says there are no 3.6 implementations that don't 
guarantee insertion order for dict.

--
assignee: eric.smith
messages: 309587
nosy: eric.smith
priority: normal
severity: normal
status: open
title: dataclasses: no need for OrderedDict now that dict guarantees to keep 
insertion order
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com