[issue32805] Possible integer overflow when call PyDTrace_GC_DONE()

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32805] Possible integer overflow when call PyDTrace_GC_DONE()

[STINNER Victor]

STINNER Victor  added the comment:

The warning in the C code has been fixed by:

New changeset edad38e3e05586ba58291f47756eb3fb808f5577 by Victor Stinner 
(Jeremy Kloth) in branch 'master':
bpo-9566: Fix compiler warnings in gcmodule.c (GH-11010)
https://github.com/python/cpython/commit/edad38e3e05586ba58291f47756eb3fb808f5577

The remaining question is if Include/pydtrace.d must be updated or not:
https://github.com/python/cpython/pull/11010#issuecomment-470187843

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32805] Possible integer overflow when call PyDTrace_GC_DONE()

[STINNER Victor]

STINNER Victor  added the comment:

I don't think that Python 3.7 should be modified. I prefer to avoid any risk 
and only modify Python 3.8.

--
versions:  -Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32805] Possible integer overflow when call PyDTrace_GC_DONE()

[Jeremy Kloth]

Change by Jeremy Kloth :


--
keywords: +patch
pull_requests: +10247
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32805] Possible integer overflow when call PyDTrace_GC_DONE()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

DTrace support was implemented in issue21590 (changeset 
a785c87d6eacbed81543a8afe3cb098fabb9610a).

--
nosy: +jcea
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32805] Possible integer overflow when call PyDTrace_GC_DONE()

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

PyDTrace_GC_DONE() accepts the argument of type int. But it is called with the 
sum of collected and uncollectable objects which has type Py_ssize_t and can be 
larger that maximal int.

This produces a compiler warning on Windows:

..\Modules\gcmodule.c(978): warning C4244: 'function': conversion from 
'Py_ssize_t' to 'int', possible loss of data 
[D:\buildarea\3.x.bolen-windows10\build\PCbuild\pythoncore.vcxproj]

and looks as not false alarm.

--
components: Interpreter Core
messages: 311870
nosy: lukasz.langa, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Possible integer overflow when call PyDTrace_GC_DONE()
type: behavior
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com