[issue32957] distutils.command.install checks truthiness of .ext_modules instead of calling .has_ext_modules()

[Steve Dower]

Steve Dower  added the comment:

Distutils is now deprecated (see PEP 632) and all tagged issues are being 
closed. From now until removal, only release blocking issues will be considered 
for distutils.

If this issue does not relate to distutils, please remove the component and 
reopen it. If you believe it still requires a fix, most likely the issue should 
be re-reported at https://github.com/pypa/setuptools

--
nosy: +steve.dower
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32957] distutils.command.install checks truthiness of .ext_modules instead of calling .has_ext_modules()

[Korijn Van Golen]

Change by Korijn Van Golen :


--
keywords: +patch
pull_requests: +5679
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32957] distutils.command.install checks truthiness of .ext_modules instead of calling .has_ext_modules()

[Korijn Van Golen]

New submission from Korijn Van Golen :

distutils' Distribution class has a method has_ext_modules() that is used to 
determine if any extension modules are included in a distribution. There 
remains a call site in distutils.command.install where 
self.distribution.ext_modules is directly tested for truthiness, rather than 
calling has_ext_modules. This causes inconsistent behavior, e.g. when 
overriding has_ext_modules in a Distribution subclass.

--
components: Distutils
messages: 312932
nosy: Korijn Van Golen, dstufft, eric.araujo
priority: normal
severity: normal
status: open
title: distutils.command.install checks truthiness of .ext_modules instead of 
calling .has_ext_modules()
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com