[issue34010] tarfile stream read performance regression

[STINNER Victor]

STINNER Victor  added the comment:

> @Victor I think removing unused code is better than adding test for it and 
> maintain it.

Sure. I reviewed your PR 8089.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34010] tarfile stream read performance regression

[INADA Naoki]

INADA Naoki  added the comment:

@Victor I think removing unused code is better than adding test for it and 
maintain it.

So I removed that unused code block in GH-8089.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34010] tarfile stream read performance regression

[miss-islington]

miss-islington  added the comment:


New changeset d7a0ad7dd7bd7dfbdbf6be2c89fde5a71813628a by Miss Islington (bot) 
in branch '3.6':
bpo-34010: Fix tarfile read performance regression (GH-8020)
https://github.com/python/cpython/commit/d7a0ad7dd7bd7dfbdbf6be2c89fde5a71813628a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34010] tarfile stream read performance regression

[miss-islington]

miss-islington  added the comment:


New changeset c1b75b5fb92fda0ac5b931d7b18c1418557cb7c4 by Miss Islington (bot) 
in branch '3.7':
bpo-34010: Fix tarfile read performance regression (GH-8020)
https://github.com/python/cpython/commit/c1b75b5fb92fda0ac5b931d7b18c1418557cb7c4


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34010] tarfile stream read performance regression

[STINNER Victor]

STINNER Victor  added the comment:

https://github.com/python/cpython/pull/8020/files/77a54a39aace1a38794884218abe801b85b54e62#diff-ef64d8b610dda67977a63a9837f46349

-buf = "".join(t)
+buf = b"".join(t)


@hajoscher: "It never caused a problem, since this line is never called; size 
is never None in the function call. But still, should be fixed, I guess."

Would it be possible to have an unit test for this modified line? Untested code 
is broken, as you showed :-)

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34010] tarfile stream read performance regression

[INADA Naoki]

INADA Naoki  added the comment:

thanks

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34010] tarfile stream read performance regression

[miss-islington]

Change by miss-islington :


--
pull_requests: +7683

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34010] tarfile stream read performance regression

[miss-islington]

Change by miss-islington :


--
pull_requests: +7684

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34010] tarfile stream read performance regression

[INADA Naoki]

INADA Naoki  added the comment:


New changeset 12a08c47601cadea8e7d3808502cdbcca87b2ce2 by INADA Naoki 
(hajoscher) in branch 'master':
bpo-34010: Fix tarfile read performance regression (GH-8020)
https://github.com/python/cpython/commit/12a08c47601cadea8e7d3808502cdbcca87b2ce2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34010] tarfile stream read performance regression

[INADA Naoki]

Change by INADA Naoki :


--
keywords: +3.2regression
title: tarfile stream read performance -> tarfile stream read performance 
regression

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com