[issue34323] False timeout log message on proactor close

[STINNER Victor]

STINNER Victor  added the comment:

Ok, the bug is now fixed. Thanks for your bug report John Nelson!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[STINNER Victor]

STINNER Victor  added the comment:


New changeset d5a6adf6285ec8892b977a32c22143ebd1025b50 by Victor Stinner in 
branch '3.7':
[3.7] bpo-34323: Enhance IocpProactor.close() log (GH-11565)
https://github.com/python/cpython/commit/d5a6adf6285ec8892b977a32c22143ebd1025b50


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[STINNER Victor]

STINNER Victor  added the comment:

Oops, I used the wrong bpo number for my second change in master:

New changeset b91140fdb17472d03a7b7971f143c08a40fde923 by Victor Stinner in 
branch 'master':
bpo-11555: Enhance IocpProactor.close() log again (GH-11563)
https://github.com/python/cpython/commit/b91140fdb17472d03a7b7971f143c08a40fde923

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +11225, 11226

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +11225

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[STINNER Victor]

STINNER Victor  added the comment:


New changeset b1e45739d832e1e402a563c6727defda92e193b7 by Victor Stinner in 
branch 'master':
bpo-34323: Enhance IocpProactor.close() log (GH-11555)
https://github.com/python/cpython/commit/b1e45739d832e1e402a563c6727defda92e193b7


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +11190, 11191, 11192

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +11190

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +11190, 11191

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch, patch
pull_requests: +11013, 11014
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch, patch, patch
pull_requests: +11013, 11014, 11015
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +11013
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[John Nelson]

John Nelson  added the comment:

Python 3.5.4 (v3.5.4:3f56838, Aug  8 2017, 02:17:05) [MSC v.1900 64 bit 
(AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import platform, sys
>>> platform.win32_ver()
('2012ServerR2', '6.3.9600', 'SP0', 'Multiprocessor Free')
>>> sys.version_info
sys.version_info(major=3, minor=5, micro=4, releaselevel='final', serial=0)

--
nosy: +John Nelson2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

Hi johnboy2,

thank you for your issue, but could you send us more information about your 
platform?

thank you

--
nosy: +matrixise

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[John Nelson]

John Nelson  added the comment:

I *suspect* the issue is down to a discrepancy between:
- IocpProactor.close(), and
- IocpProactor._poll()

When the former calls the latter, it seems to be expecting a truth value 
response from _poll() to indicate that no timeout occurred. However, the latter 
only ever returns None.

Of note is that `ms != 0` whenever a timeout occurs, potentially giving a 
simple test point.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34323] False timeout log message on proactor close

[John Nelson]

New submission from John Nelson :

Repro:
 1. Run the attached script ('repro.py')

Expected output:

2018-07-31 16:39:57,069 - asyncio - DEBUG - Using proactor: IocpProactor
2018-07-31 16:39:57,084 - root - INFO - Starting
2018-07-31 16:39:58,100 - root - INFO - Sleep done
2018-07-31 16:39:58,100 - root - INFO - Loop closed

Actual output:

2018-07-31 16:37:58,583 - asyncio - DEBUG - Using proactor: IocpProactor
2018-07-31 16:37:58,599 - root - INFO - Starting
2018-07-31 16:37:59,614 - root - INFO - Sleep done
2018-07-31 16:37:59,614 - asyncio - DEBUG - taking long time to close proactor
2018-07-31 16:37:59,614 - root - INFO - Loop closed

--
components: asyncio
files: repro.py
messages: 322994
nosy: asvetlov, johnboy2, yselivanov
priority: normal
severity: normal
status: open
title: False timeout log message on proactor close
type: behavior
versions: Python 3.5
Added file: https://bugs.python.org/file47730/repro.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com