[issue34789] doc xml.sax.make_parser expects a list not just any sequence

[Andrés Delfino]

Change by Andrés Delfino :


--
pull_requests: +8978

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34789] doc xml.sax.make_parser expects a list not just any sequence

[Fred L. Drake, Jr.]

Fred L. Drake, Jr.  added the comment:

The existing PR can be re-targeted to merge to a maintenance branch (I'd be 
inclined to merge manually, myself, but will have to check the current devguide 
to make sure that's still allowed).

A new PR can be made for the non-documentation fix for master.

My thought is that a PR is more about the patch than about the workflow; a 
different patch can be handled in a separate PR, and review & discussion are 
used to determine which PR should be applied where.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34789] doc xml.sax.make_parser expects a list not just any sequence

[Andrés Delfino]

Andrés Delfino  added the comment:

Admittedly, my Git-fu is not strong, but since the PR was opened against 
master, and given that the PR as is won't be merged to master, can it still be 
"backported" to 3.7, 3.6, and 2.7?

Shouldn't I update the PR so it can be merged to master (that won't be 
backported), and then open a new PR against 3.7 that will be backported to 3.6 
and 2.7?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34789] doc xml.sax.make_parser expects a list not just any sequence

[Fred L. Drake, Jr.]

Fred L. Drake, Jr.  added the comment:

It probably makes more sense to keep that PR for the maintenance branches, and 
create a new branch / PR to land on master.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34789] doc xml.sax.make_parser expects a list not just any sequence

[Andrés Delfino]

Andrés Delfino  added the comment:

I think it makes sense for make_parser to accept any iterable too. I'll update 
the PR when I have the testcase ready.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34789] doc xml.sax.make_parser expects a list not just any sequence

[Fred L. Drake, Jr.]

Fred L. Drake, Jr.  added the comment:

I'm just going to presume this issue has been around a long time, but I think 
that's a pretty safe presumption.

Accepting a general sequence instead of only a list would reasonable, and I'd 
support a fix that caused the code to accept a general sequence (or any 
iterable) by calling list() on the passed-in value, starting with 3.8.

The patch provided looks good for versions in maintenance.  (It would also be 
fine for 3.8 if there's no interest in generalizing the code to accept 
arbitrary iterables).

--
nosy: +fdrake

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34789] doc xml.sax.make_parser expects a list not just any sequence

[Andrés Delfino]

Change by Andrés Delfino :


--
keywords: +patch
pull_requests: +8944
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34789] doc xml.sax.make_parser expects a list not just any sequence

[Andrés Delfino]

New submission from Andrés Delfino :

Doc says:

"If parser_list is provided, it must be a *sequence* of strings which name 
modules that have a function named create_parser()"

but code concatenas parser_list with an existing list:

for parser_name in parser_list + default_parser_list:

Fix this by stating parser_list must be a specific kind of sequence, that is, a 
list.

--
assignee: docs@python
components: Documentation
messages: 326261
nosy: adelfino, docs@python
priority: normal
severity: normal
status: open
title: doc xml.sax.make_parser expects a list not just any sequence
type: enhancement
versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com