[issue34871] test_site fails if run after test_inspect

[Yury Selivanov]

Yury Selivanov  added the comment:

Thank you Inada-san for taking care of this.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[Yury Selivanov]

Yury Selivanov  added the comment:


New changeset 476c294f260ebe1b44157a168c3dfa4a43724ce3 by Yury Selivanov (Miss 
Islington (bot)) in branch '3.7':
bpo-34871: inspect: Don't pollute sys.modules (GH-9696) (#9701)
https://github.com/python/cpython/commit/476c294f260ebe1b44157a168c3dfa4a43724ce3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[Yury Selivanov]

Yury Selivanov  added the comment:


New changeset 70a083bc46aea84e3b3ffca2c10c295917a98fec by Yury Selivanov (Miss 
Islington (bot)) in branch '3.6':
bpo-34871: inspect: Don't pollute sys.modules (GH-9696) (GH-9702)
https://github.com/python/cpython/commit/70a083bc46aea84e3b3ffca2c10c295917a98fec


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[miss-islington]

Change by miss-islington :


--
pull_requests: +9087

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[miss-islington]

Change by miss-islington :


--
pull_requests: +9086

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[miss-islington]

miss-islington  added the comment:


New changeset 6f85b826b527e240551613aeec3118a5469e3a33 by Miss Islington (bot) 
(INADA Naoki) in branch 'master':
bpo-34871: inspect: Don't pollute sys.modules (GH-9696)
https://github.com/python/cpython/commit/6f85b826b527e240551613aeec3118a5469e3a33


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[miss-islington]

miss-islington  added the comment:


New changeset c57eb9a336391dc22aa29e9db592fa06d7fb7101 by Miss Islington (bot) 
(Chih-Hsuan Yen) in branch 'master':
bpo-34871: Fix two typos in test_inspect.py (GH-9698)
https://github.com/python/cpython/commit/c57eb9a336391dc22aa29e9db592fa06d7fb7101


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[Chih-Hsuan Yen]

Change by Chih-Hsuan Yen :


--
pull_requests: +9084

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[INADA Naoki]

Change by INADA Naoki :


--
keywords: +patch
pull_requests: +9083
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[Chih-Hsuan Yen]

Chih-Hsuan Yen  added the comment:

Thanks very much for the test.bisect hint! After some more trials, I guess it's 
an issue in the `inspect` module rather than the newly-added test in test_site. 
Here's an example script:


import inspect
import sys
import _testcapi

builtin = _testcapi.docstring_with_signature_with_defaults
spec = inspect.getfullargspec(builtin)
print(type(sys.modules['__builtins__']))


After inspect.getfullargspec(), sys.modules['__builtins__'] is a dict. That's a 
little bit strange as every other item in sys.modules is a module.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

The failing test was added with d4c76d960b8b286b75c933780416ace9cda682fd


commit d4c76d960b8b286b75c933780416ace9cda682fd
Author: INADA Naoki 
Date:   Mon Oct 1 21:10:37 2018 +0900

bpo-30167: Add test for module.__cached__ is None (GH-7617)

diff --git a/Lib/test/test_site.py b/Lib/test/test_site.py
index dc59e5917c..33a8f1a44c 100644
--- a/Lib/test/test_site.py
+++ b/Lib/test/test_site.py
@@ -389,6 +389,17 @@ class ImportSideEffectTests(unittest.TestCase):
 "expected absolute path, got {}"
 .format(os__cached__.decode('ascii')))

+def test_abs_paths_cached_None(self):
+"""Test for __cached__ is None.
+
+Regarding to PEP 3147, __cached__ can be None.
+
+See also: https://bugs.python.org/issue30167
+"""
+sys.modules['test'].__cached__ = None
+site.abs_paths()
+self.assertIsNone(sys.modules['test'].__cached__)
+


# Latest master

➜  cpython git:(master) ./python.exe -m test.regrtest test_inspect test_site
Run tests sequentially
0:00:00 load avg: 1.75 [1/2] test_inspect
0:00:02 load avg: 1.75 [2/2] test_site
test test_site failed -- Traceback (most recent call last):
  File 
"/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/test/test_site.py", 
line 400, in test_abs_paths_cached_None
site.abs_paths()
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/site.py", line 
101, in abs_paths
for m in set(sys.modules.values()):
TypeError: unhashable type: 'dict'

test_site failed

== Tests result: FAILURE ==

1 test OK.

1 test failed:
test_site

Total duration: 2 sec 868 ms
Tests result: FAILURE


➜  cpython git:(master) git checkout d4c76d960b8b286b75c933780416ace9cda682fd~1 
Lib/test/test_site.py
➜  cpython git:(master) ✗ ./python.exe -m test.regrtest test_inspect test_site
Run tests sequentially
0:00:00 load avg: 1.49 [1/2] test_inspect
0:00:02 load avg: 1.49 [2/2] test_site

== Tests result: SUCCESS ==

All 2 tests OK.

Total duration: 2 sec 848 ms
Tests result: SUCCESS

Adding INADA Naoki for thoughts.


Thanks

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[Chih-Hsuan Yen]

New submission from Chih-Hsuan Yen :

$ ./python -m test.regrtest test_inspect test_site
Run tests sequentially
0:00:00 load avg: 0.03 [1/2] test_inspect
0:00:00 load avg: 0.03 [2/2] test_site
test test_site failed -- Traceback (most recent call last):
  File "/home/yen/Projects/cpython/Lib/test/test_site.py", line 400, in 
test_abs_paths_cached_None
site.abs_paths()
  File "/home/yen/Projects/cpython/Lib/site.py", line 101, in abs_paths
for m in set(sys.modules.values()):
TypeError: unhashable type: 'dict'

test_site failed


If I run test_inspect or test_site individually, both pass. Full log can be 
found in the attached file.

Environment: Arch Linux x86_64 latest. CPython commit 
81574b80e92554adf75c13fa42415beb8be383cb, configured with `./configure`

--
components: Tests
files: cpython-failure.txt
messages: 326881
nosy: yan12125
priority: normal
severity: normal
status: open
title: test_site fails if run after test_inspect
type: behavior
versions: Python 3.8
Added file: https://bugs.python.org/file47842/cpython-failure.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34871] test_site fails if run after test_inspect

[STINNER Victor]

STINNER Victor  added the comment:

You can try to limit the number of tests needed to reproduce the bug using:

./python -m test.bisect -n 5 test_inspect test_site

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com