[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[STINNER Victor]

STINNER Victor  added the comment:

Ok, test_socket should depend a little bit less on time now ;-)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 304315d251dbb4e85dd86056ba1925f25e646ca1 by Victor Stinner in 
branch 'master':
bpo-35347: Cleanup test_socket.NonBlockingTCPTests (GH-10818)
https://github.com/python/cpython/commit/304315d251dbb4e85dd86056ba1925f25e646ca1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[STINNER Victor]

STINNER Victor  added the comment:


New changeset dab59fa56054d6c0f75ae7013337f7baaa248076 by Victor Stinner in 
branch '2.7':
bpo-35347: Fix test_socket.NonBlockingTCPTests (GH-10791) (GH-10817)
https://github.com/python/cpython/commit/dab59fa56054d6c0f75ae7013337f7baaa248076


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[miss-islington]

miss-islington  added the comment:


New changeset af7e81f71858519de8d2bafcb38fce8cca86aa0a by Miss Islington (bot) 
in branch '3.6':
bpo-35347: Fix test_socket.NonBlockingTCPTests (GH-10791)
https://github.com/python/cpython/commit/af7e81f71858519de8d2bafcb38fce8cca86aa0a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +10062

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[miss-islington]

miss-islington  added the comment:


New changeset 365f21c2d3756a6768c5b0d479aaf5c2a568b80b by Miss Islington (bot) 
in branch '3.7':
bpo-35347: Fix test_socket.NonBlockingTCPTests (GH-10791)
https://github.com/python/cpython/commit/365f21c2d3756a6768c5b0d479aaf5c2a568b80b


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +10061

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[miss-islington]

Change by miss-islington :


--
pull_requests: +10060

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[STINNER Victor]

STINNER Victor  added the comment:


New changeset ebd5d6d6e6e4e751ba9c7534004aadfc27ba9265 by Victor Stinner in 
branch 'master':
bpo-35347: Fix test_socket.NonBlockingTCPTests (GH-10791)
https://github.com/python/cpython/commit/ebd5d6d6e6e4e751ba9c7534004aadfc27ba9265


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[miss-islington]

Change by miss-islington :


--
pull_requests: +10059

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +10038
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35347] test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as synchronization

[STINNER Victor]

New submission from STINNER Victor :

Failure seen on the Windows XP buildbot:

https://buildbot.python.org/all/#/builders/45/builds/288

0:02:14 [ 35/404/1] test_socket failed
test test_socket failed -- Traceback (most recent call last):
  File 
"d:\cygwin\home\db3l\buildarea\2.7.bolen-windows\build\lib\test\test_socket.py",
 line 1020, in testRecv
self.fail("Error trying to do non-blocking recv.")
AssertionError: Error trying to do non-blocking recv.

In fact, the master branch still uses the weak 100 ms sleep as synchronization 
primitive :-(

Attached PR replaces time.sleep() with a threading.Event().

--
components: Tests
messages: 330671
nosy: vstinner
priority: normal
severity: normal
status: open
title: test_socket: NonBlockingTCPTests.testRecv() uses a weak 100 ms sleep as 
synchronization
versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com