[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Şahin]

Şahin  added the comment:

OK, thank you all for information. It's now clear for me too why this is not an 
issue. I'll try to close this issue by selecting status as close but if it 
isn't working with this way (I'm new, I don't know how) anyone can close this.

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

They are not in the __all__ list and are not documented. If __all__ is defined 
for the module, there is no need to use the underscore prefix for private 
globals. The calendar module is not special, many other modules follow this 
convention.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Paul Ganssle]

Paul Ganssle  added the comment:

Might it be worth moving `nextmonth` and `prevmonth` to `calendar._nextmonth` 
and `calendar._prevmonth` to make it more clear that these are private methods?

Due to Hyrum's Law, people will be using them anyway, but it could have a short 
deprecation period where `calendar.nextmonth` and `calendar.prevmonth` raise 
DeprecationWarning and then call `calendar._nextmonth` and 
`calendar._prevmonth`.

--
nosy: +p-ganssle

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

> On Dec 4, 2018, at 10:27 AM, Şahin  wrote:
> 
> Is there anything similar to this for "public API functions"?

Yes - read the reference manual. If the function is not there it is not public.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Şahin]

Şahin  added the comment:

OK now it isn't a problem if we shouldn't use this function directly but how am 
i going to understand if a function is public API or not? In classes, we are 
using single or double underscore to indicate that the function or variable 
we're declaring is intended to be private. Is there anything similar to this 
for "public API functions" or am I in the wrong way?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[శ్రీనివాస్ రెడ్డి తాటిపర్తి]

Srinivas  Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) 
 added the comment:

I agree with Serhiy, nextmonth() is not a public API,you should not use it.

--
nosy: +thatiparthy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

nextmonth() is not a public API. You should not use it.

If you want to make IllegalMonthError be always raised instead of IndexError 
for out of range month values, this is a different issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Şahin]

Şahin  added the comment:

I'm suggesting this idea to consistency. Why an IllegalMonthError exists in 
calendar module if we don't raise this error when required?

What would you say if I asked you to "What is the month number coming after 
156th month?" Would you say 157 or prefer to inform me that I'm doing something 
wrong?

>>> import calendar
>>> calendar.nextmonth(2018, 12)
(2019, 1)

If Python is smart enough to jump next year's first month and not say (2018, 
13) blindly, it should also check if the given month is valid. 

But:
>>> calendar.nextmonth(2018, 157)
(2018, 158)

I think this is clearly a bug in the code.


---

I'll wander away from the this issue but some of the functions in calendar 
module also not consistent with each other:

>>> calendar.monthcalendar(2018, 12) # Runs with no problem.
>>> calendar.monthcalendar(2018, 0)  # Raises IllegalMonthError.
>>> calendar.monthcalendar(2018, 13) # Raises IllegalMonthError.

>>> calendar.month(2018, 12) # Runs with no problem.
>>> calendar.month(2018, 0)  # Raises IllegalMonthError.
>>> calendar.month(2018, 13) # Raises IndexError???

Why? Wouldn't it be more reasonable if the last one also had raised 
IllegalMonthError? 

>>> calendar.monthrange(2018, 12) # Runs with no problem.
>>> calendar.monthrange(2018, 0)  # Raises IllegalMonthError.
>>> calendar.monthrange(2018, 13) # Raises IllegalMonthError.

>>> calendar.prmonth(2018, 12) # Runs with no problem.
>>> calendar.prmonth(2018, 0)  # Raises IllegalMonthError.
>>> calendar.prmonth(2018, 13) # Raises IndexError.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

What is the problem with current code? Can you provide an example that doesn't 
work correctly?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Şahin]

Şahin  added the comment:

I understand you but i still think these functions need to check it. As an 
end-user, I shouldn't see these functions to work with no errors for illegal 
months.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

prevmonth() and nextmonth() are internal functions. They are used only in 
itermonthdays3(), and the month is already checked before calling them.

--
nosy: +belopolsky, rhettinger, serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Şahin]

Change by Şahin :


--
keywords: +patch
pull_requests: +10128
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35406] calendar.nextmonth and calendar.prevmonth functions doesn't check if the month is valid

[Şahin]

New submission from Şahin :

import calendar
calendar.nextmonth(2018, 11) returns (2018, 12) which is OK.
calendar.nextmonth(2018, 12) returns (2019, 1) which is also OK.
calendar.nextmonth(2018, 13) returns (2018, 14). It would make more sense if 
this was raise calendar.IllegalMonthError.

--
components: Library (Lib)
messages: 331031
nosy: asocia
priority: normal
severity: normal
status: open
title: calendar.nextmonth and calendar.prevmonth functions doesn't check if the 
month is valid

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com