[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Steve Dower]

Steve Dower  added the comment:

As mentioned above, those changes are other improvements that were worth 
taking, and about half of the required manylinux1 changes. But we probably need 
to maintain our own manylinux image for building/running CPython tests, if we 
want to do it. The existing images are all designed for having CPython already 
present to build a range of binaries, which is not at all our use case.

--
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Steve Dower]

Steve Dower  added the comment:


New changeset 128efcade63480b5860a6d045a41ba4abf5eea2f by Steve Dower in branch 
'3.7':
bpo-35683: Improve Azure Pipelines steps (GH-11493)
https://github.com/python/cpython/commit/128efcade63480b5860a6d045a41ba4abf5eea2f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Steve Dower]

Change by Steve Dower :


--
pull_requests: +11438, 11439, 11440

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Steve Dower]

Change by Steve Dower :


--
pull_requests: +11438, 11439

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Steve Dower]

Change by Steve Dower :


--
pull_requests: +11438

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Steve Dower]

Steve Dower  added the comment:


New changeset 28f6cb34f602b9796987904a607dceaf2e4a9e78 by Steve Dower in branch 
'master':
bpo-35683: Improve Azure Pipelines steps (GH-11493)
https://github.com/python/cpython/commit/28f6cb34f602b9796987904a607dceaf2e4a9e78


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I believe it was Louie Lu's idea, #30290, to check more than one line.
I am glad it helped.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Steve Dower]

Steve Dower  added the comment:

I have made the changes I suggested (though correctly...), but ultimately we 
need to create our own Docker image suitable for running these tests.

So for now, I'm proposing in my PR to make most of the change, as well as a few 
other Pipelines/test-related improvements, but to leave this open in case 
someone wants to come in later with a suitable image. At that point, the only 
change necessary to enable the tests will be to add a "posix_deps_yum.sh" 
script, update the image name/tag and change the manylinux variable to 'true'.

PR 11493 also fixes a missing LICENSE.txt file in the app store package, which 
was causing an idlelib test to fail as the fallback text only has one line. 
*Way* too obscure a failure for my liking, but at least we had a test there, so 
thanks, Terry :)

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Steve Dower]

Change by Steve Dower :


--
keywords: +patch, patch, patch
pull_requests: +11010, 11011, 11012
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Steve Dower]

Change by Steve Dower :


--
keywords: +patch
pull_requests: +11010
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Steve Dower]

Change by Steve Dower :


--
keywords: +patch, patch
pull_requests: +11010, 11011
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines for CI testing

[Brett Cannon]

Change by Brett Cannon :


--
title: Enable manylinux1 builds on Pipelines -> Enable manylinux1 builds on 
Pipelines for CI testing

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35683] Enable manylinux1 builds on Pipelines

[Steve Dower]

New submission from Steve Dower :

Azure Pipelines can now support container jobs: 
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/container-phases?view=vsts&tabs=yaml

I experimented with enabling a manylinux1 build a while back, which should now 
be able to use identical steps to the POSIX build. With the new syntax, we can 
enable CI (and perhaps PR?) builds using the snippet below:

- job: ManyLinux1_CI_Tests
  displayName: ManyLinux1 CI Tests
  dependsOn: Prebuild
  condition: |
and(
and(
succeeded(),
eq(variables['manylinux'], 'true')
),
eq(dependencies.Prebuild.outputs['tests.run'], 'true')
)

  resources:
containers:
- container: manylinux1
  image: dockcross:manylinux-x64

  pool:
vmImage: ubuntu-16.04

  container: manylinux1

  variables:
testRunTitle: '$(build.sourceBranchName)-manylinux1'
testRunPlatform: manylinux1

  steps:
  - template: ./posix-steps.yml


I don't have time right now to test this change, but someone else might. It's 
certainly going to be easier for someone to test it by adding this to the PR 
build first (or set up a build on your own Pipelines instance).

Maybe there are other more relevant containers we should be testing in?

--
components: Cross-Build
messages: 333209
nosy: Alex.Willmer, barry, steve.dower, zach.ware
priority: normal
severity: normal
status: open
title: Enable manylinux1 builds on Pipelines
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com