[issue35697] _decimal: Implement the previously rejected changes from #7442.

[STINNER Victor]

STINNER Victor  added the comment:

I'm no longer interested to rewrite my patch to avoid 
_Py_GetLocaleconvNumeric() which comes from the internal API, so I close my PR.

--
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35697] _decimal: Implement the previously rejected changes from #7442.

[Raymond Hettinger]

Raymond Hettinger  added the comment:

> Sometimes not being dependent on API functions is a virtue if the code does 
> not change very often.

That is a reasonable position to take.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35697] _decimal: Implement the previously rejected changes from #7442.

[Stefan Krah]

Stefan Krah  added the comment:

I mean issue reports like #33954 or #35195.  These are just
two examples, and I'm NOT claiming that they are related.

But if functions like _PyUnicode_InsertThousandsGrouping()
*were* used in _decimal, I'd feel compelled to investigate.

Now I don't have to. I'd investigate #35195 for example, perhaps
just to find out that it has an entirely different cause.


Sometimes not being dependent on API functions is a virtue if
the code does not change very often.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35697] _decimal: Implement the previously rejected changes from #7442.

[STINNER Victor]

STINNER Victor  added the comment:

Extract of Stefan Krah's msg333296 of bpo-35638:

> So why would you think that I'm not aware of that issue?

Oh, I never said that.

I wrote "By the way, the decimal module doesn't support properly the following 
corner case: LC_NUMERIC using an encoding different than LC_CTYPE encoding. I 
wrote https://github.com/python/cpython/pull/5191 but I abandonned my change." 
as a reminder for myself. I found again the bug when I wrote my article, and I 
realized that I abandoned my PR when I had my burnout, and not because the fix 
was "officially" rejected.

So I opened this issue to get an official statement :-)


> It has low priority for me and I hesitate to depend on the official locale 
> functions in decimal because I don't want to be involved in additional issue 
> reports in that area.

As I wrote in my PR, I'm not very happy of my proposed implementation. But 
let's discuss options to fix it :-)

I don't understand "I don't want to be involved in additional issue reports in 
that area". If the bug is fixed, why do you expect more bug reports? You wrote 
that nobody reported any issue related to formatting a decimal number using the 
locale since 2009.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35697] _decimal: Implement the previously rejected changes from #7442.

[STINNER Victor]

STINNER Victor  added the comment:

Oh, I forgot to mention the context: I reported this issue as follow-up to 
discussions on bpo-35638: "Introduce fixed point locale aware format type for 
floating point numbers".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35697] _decimal: Implement the previously rejected changes from #7442.

[STINNER Victor]

STINNER Victor  added the comment:

Stefan Krah:
> Don't you find it strange to close #7442 in mutual agreement and now
mention the word "bug" 50 times?

We agreed to close the bug in 2014. In the meanwhile, more and more people 
reported the same bug (multiple similar bug reports and more and more frequent 
messages). So I decided to fix the bug instead of explaining to users that they 
must not do that :-)


> Also Marc-Andre does not consider this a bug in #31900.  The
presentation of this issue is increasingly bizarre.

Aha, maybe I misunderstood him when he wrote (msg309981):

"Sounds like a good compromise :-)"

--

I'm not sure of what you are asking here. You are the maintainer of the decimal 
module. If you consider that it's not worth it, just close the issue. It's up 
to you ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35697] _decimal: Implement the previously rejected changes from #7442.

[Stefan Krah]

Stefan Krah  added the comment:

Also Marc-Andre does not consider this a bug in #31900.  The
presentation of this issue is increasingly bizarre.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35697] _decimal: Implement the previously rejected changes from #7442.

[Stefan Krah]

Change by Stefan Krah :


--
title: decimal: formatter error if LC_NUMERIC uses a different encoding than 
LC_CTYPE -> _decimal: Implement the previously rejected changes from #7442.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com