[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

@Steve, we are investigating and tracking this issue here:

https://bugs.python.org/issue35795

According to the buildbot owner "directory tree removal needs to go through 
support.rmtree, not any of the stdlib methods for doing so.  In a nutshell, the 
tests need to be changed to do this".

Not sure why this has happened now

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Tzu-ping Chung]

Tzu-ping Chung  added the comment:

I read a few of the logs, and all errors roots in the same place, when the test 
case tries to remove the tempdir during teardown/cleanup. The Windows (and 
other platforms not supporting directory fds) implementation of rmtree can have 
race conditions if files are added while the directory being walked, causing 
the error.

I don’t know the case of CPython, but Pipenv has a similar problem when running 
concurrent tests with subprocesses. We never solved it (but simply wrap the 
rmtree call inside a try block and look away).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Steve Dower]

Steve Dower  added the comment:

There is one buildbot 
(https://buildbot.python.org/all/#builders/40/builds/1524) that started 
randomly failing unrelated tests with this change - usually one of zipapp, 
pkgutil, or zipimport. I don't have any idea what the relationship here is, 
unless the distutils tests have stopped skipping on those machines and are 
affecting some sort of global state (which they shouldn't, and the other tests 
shouldn't be relying on, but here we are).

I haven't looked at the actual tests (from my phone) yet. Anyone have any 
better ideas?

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Ned Deily]

Ned Deily  added the comment:

Merged on behalf of Steve.  Thanks, Marc!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[miss-islington]

miss-islington  added the comment:


New changeset 2fa53cfa8960f4bcb36718da4424e980fc305ef5 by Miss Islington (bot) 
in branch '3.7':
bpo-35699: fix distuils cannot detect Build Tools 2017 anymore (GH-11495)
https://github.com/python/cpython/commit/2fa53cfa8960f4bcb36718da4424e980fc305ef5


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[miss-islington]

Change by miss-islington :


--
pull_requests: +11389, 11390, 11391

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[miss-islington]

Change by miss-islington :


--
pull_requests: +11389, 11390

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[miss-islington]

Change by miss-islington :


--
pull_requests: +11389

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Ned Deily]

Ned Deily  added the comment:


New changeset b2dc4a3313c236fedbd6df664722cd47f3d91a72 by Ned Deily (Marc 
Schlaich) in branch 'master':
bpo-35699: fix distuils cannot detect Build Tools 2017 anymore (GH-11495)
https://github.com/python/cpython/commit/b2dc4a3313c236fedbd6df664722cd47f3d91a72


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Steve Dower]

Steve Dower  added the comment:

Reminder to myself (or permission for anyone else) to merge this. My phone 
won't let me actually click the github merge button, unfortunately, but this 
seems good to go.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Tzu-ping Chung]

Change by Tzu-ping Chung :


--
nosy: +uranusjr

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Marc Schlaich]

Change by Marc Schlaich :


--
keywords: +patch, patch
pull_requests: +11016, 11017
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Marc Schlaich]

Change by Marc Schlaich :


--
keywords: +patch, patch, patch
pull_requests: +11016, 11017, 11018
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Marc Schlaich]

Change by Marc Schlaich :


--
keywords: +patch
pull_requests: +11016
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Marc Schlaich]

Marc Schlaich  added the comment:

We are passing arguments

 -latest(Return only the newest version and last installed.)

and

 "-requires", "Microsoft.VisualStudio.Component.VC.Tools.x86.x64",

So this should handle the cases multiple installs and different products 
without compilers.

I try to get a PR ready.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Steve Dower]

Steve Dower  added the comment:

Excellent catch! Are you interested in creating a PR?

Also, I don't recall whether we are handling multiple installs or not, but if 
we are not I would rather explicitly list the products that may include 
compilers than using "*" (since there are and will be more products that do 
not). If we're checking for installed packages as well and iterating over all 
results then "*" will be fine.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

[Marc Schlaich]

New submission from Marc Schlaich :

vshwere.exe doesn't return Build Tools 2017 per default. This means Build Tools 
2017 are not detected by distutils in 3.7.2 and you get the famous "Microsoft 
Visual C++ 14.0 is required" error.

Please see https://github.com/Microsoft/vswhere/issues/125 for more details.

The solution is to add 

"-products", "*",

to the vswhere.exe call.

This is a regression of https://bugs.python.org/issue35067.

--
components: Distutils
messages: 12
nosy: dstufft, eric.araujo, schlamar, steve.dower
priority: normal
severity: normal
status: open
title: distutils cannot find Build Tools 2017 since 3.7.2
type: behavior
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com