[issue35837] smtpd PureProxy breaks on mail_options keyword argument

[R. David Murray]

R. David Murray  added the comment:

I'm closing this in favor of #35799 because someone has to first make a 
remove-or-fix decision, which is mentioned there.

--
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder:  -> fix or remove smtpd.PureProxy
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35837] smtpd PureProxy breaks on mail_options keyword argument

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Sorry, I overlooked that one. While searching for other smtpd issues many of 
them were closed as won't fix and hence my message. Thanks for the link.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35837] smtpd PureProxy breaks on mail_options keyword argument

[Samuel Colvin]

Samuel Colvin  added the comment:

Hi, did you see https://bugs.python.org/issue35788#msg334155 later in the issue?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35837] smtpd PureProxy breaks on mail_options keyword argument

[Sjoerd]

Change by Sjoerd :


--
nosy: +samuelcolvin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35837] smtpd PureProxy breaks on mail_options keyword argument

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Thanks for the report. smtpd is deprecated in favor of aiosmtpd. Some of the 
fixes were closed in the past as won't fix. Please see 
https://bugs.python.org/issue35788#msg334088 and the discussion for deprecation 
and removal.

--
nosy: +barry, xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35837] smtpd PureProxy breaks on mail_options keyword argument

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch, patch
pull_requests: +11526, 11527
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35837] smtpd PureProxy breaks on mail_options keyword argument

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
pull_requests: +11526
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35837] smtpd PureProxy breaks on mail_options keyword argument

[Sjoerd]

New submission from Sjoerd :

According to https://python.readthedocs.io/en/stable/whatsnew/3.5.html:

The SMTPServer class now advertises the 8BITMIME extension (RFC 6152) if 
decode_data has been set True. If the client specifies BODY=8BITMIME on the 
MAIL command, it is passed to SMTPServer.process_message() via the mail_options 
keyword. (Contributed by Milan Oberkirch and R. David Murray in bpo-21795.)

This means that process_message gets a mail_options kwarg. However, the smtpd 
PureProxy and MailmanProxy don't take keyword arguments, which results in an 
exception.

One way to trigger this is to run a debug mailserver and send a mail to it:

$ python3 -m smtpd -n
error: uncaptured python exception, closing channel <__main__.SMTPChannel 
connected ('::1', 52007, 0, 0) at 0x10e7eddd8> (:process_message() got an unexpected keyword argument 
'mail_options' 
[/usr/local/Cellar/python/3.7.2_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncore.py|read|83]
 
[/usr/local/Cellar/python/3.7.2_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncore.py|handle_read_event|422]
 
[/usr/local/Cellar/python/3.7.2_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asynchat.py|handle_read|171]
 
[/usr/local/Cellar/python/3.7.2_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/smtpd.py|found_terminator|386])

--
components: Library (Lib)
messages: 334424
nosy: Sjoerder, giampaolo.rodola, r.david.murray
priority: normal
severity: normal
status: open
title: smtpd PureProxy breaks on mail_options keyword argument
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com