[issue35931] pdb: "debug print(" crashes with SyntaxError

[Zachary Ware]

Zachary Ware  added the comment:

Thanks for catching that and fixing it before 3.7.3!

--
priority: release blocker -> normal
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[miss-islington]

miss-islington  added the comment:


New changeset 1c4580d1f563173f5d6ec990b46bd38f4ae901a1 by Miss Islington (bot) 
in branch '3.7':
[3.7] bpo-35931: Gracefully handle any exception in pdb debug command 
(GH-12103) (GH-12285)
https://github.com/python/cpython/commit/1c4580d1f563173f5d6ec990b46bd38f4ae901a1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[miss-islington]

Change by miss-islington :


--
pull_requests: +12264

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[miss-islington]

miss-islington  added the comment:


New changeset 3e936431e23b424b1e4665e8165c245924f0ab02 by Miss Islington (bot) 
(Daniel Hahler) in branch 'master':
bpo-35931: Gracefully handle any exception in pdb debug command (GH-12103)
https://github.com/python/cpython/commit/3e936431e23b424b1e4665e8165c245924f0ab02


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[daniel hahler]

daniel hahler  added the comment:

Example of the API breakage:

```
/opt/python/3.8-dev/lib/python3.8/pdb.py:321: in _cmdloop
self.cmdloop()
/opt/python/3.8-dev/lib/python3.8/cmd.py:138: in cmdloop
stop = self.onecmd(line)
/opt/python/3.8-dev/lib/python3.8/pdb.py:418: in onecmd
return cmd.Cmd.onecmd(self, line)
/opt/python/3.8-dev/lib/python3.8/cmd.py:217: in onecmd
return func(arg)
pdb.py:699: in do_debug
return orig_do_debug(self, cmd)
/opt/python/3.8-dev/lib/python3.8/pdb.py:1097: in do_debug
code = compile(arg, "", "exec")
E   TypeError: compile() arg 1 must be a string, bytes or AST object
```

(via https://travis-ci.org/antocuni/pdb/jobs/504061679#L367)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[Ned Deily]

Change by Ned Deily :


--
nosy: +lukasz.langa, ned.deily
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[daniel hahler]

daniel hahler  added the comment:

Bumping.

The first (merged) patch is not sufficient, and causes even an API breakage, 
because it disallows passing in a code object (via compile()) anymore.

A better fix is waiting at https://github.com/python/cpython/pull/12103, and 
should also get backported to for 3.7.3 then (or the first backport being 
reverted).

--
resolution: fixed -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[daniel hahler]

Change by daniel hahler :


--
pull_requests: +12109
stage: resolved -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[daniel hahler]

daniel hahler  added the comment:

Re-opening: it currently still crashes with a NameError when using "debug 
doesnotexist", or "debug doesnotexist()".

Will create a new PR for this.

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[daniel hahler]

daniel hahler  added the comment:

Thanks for the review and backport!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[Zachary Ware]

Zachary Ware  added the comment:

Thanks for the patch!

--
nosy: +zach.ware
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[miss-islington]

miss-islington  added the comment:


New changeset 6f352199e4447764bc472e34352d0dff4db8a52d by Miss Islington (bot) 
in branch '3.7':
bpo-35931: Gracefully handle SyntaxError in pdb debug command (GH-11782)
https://github.com/python/cpython/commit/6f352199e4447764bc472e34352d0dff4db8a52d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[miss-islington]

miss-islington  added the comment:


New changeset 4327705cfab3eb09073ec828570bbd8f789e1611 by Miss Islington (bot) 
(Daniel Hahler) in branch 'master':
bpo-35931: Gracefully handle SyntaxError in pdb debug command (GH-11782)
https://github.com/python/cpython/commit/4327705cfab3eb09073ec828570bbd8f789e1611


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[miss-islington]

Change by miss-islington :


--
pull_requests: +11916

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[Emmanuel Arias]

Emmanuel Arias  added the comment:

ping reviewer :-)

I test this PR and work fine on Ubuntu 18.04

--
nosy: +eamanu

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
nosy: +remi.lapeyre

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[daniel hahler]

New submission from daniel hahler :

`debug print(` will make pdb crash with a SyntaxError:

% python -c '__import__("pdb").set_trace()'  
--Return--
> (1)()->None
(Pdb) print(
*** SyntaxError: unexpected EOF while parsing
(Pdb) debug print(
ENTERING RECURSIVE DEBUGGER
Traceback (most recent call last):
  File "", line 1, in 
  File "/usr/lib64/python3.7/bdb.py", line 92, in trace_dispatch
return self.dispatch_return(frame, arg)
  File "/usr/lib64/python3.7/bdb.py", line 151, in dispatch_return
self.user_return(frame, arg)
  File "/usr/lib64/python3.7/pdb.py", line 293, in user_return
self.interaction(frame, None)
  File "/usr/lib64/python3.7/pdb.py", line 352, in interaction
self._cmdloop()
  File "/usr/lib64/python3.7/pdb.py", line 321, in _cmdloop
self.cmdloop()
  File "/usr/lib64/python3.7/cmd.py", line 138, in cmdloop
stop = self.onecmd(line)
  File "/usr/lib64/python3.7/pdb.py", line 418, in onecmd
return cmd.Cmd.onecmd(self, line)
  File "/usr/lib64/python3.7/cmd.py", line 217, in onecmd
return func(arg)
  File "/usr/lib64/python3.7/pdb.py", line 1099, in do_debug
sys.call_tracing(p.run, (arg, globals, locals))
  File "/usr/lib64/python3.7/bdb.py", line 582, in run
cmd = compile(cmd, "", "exec")
  File "", line 1
print(
 ^
SyntaxError: unexpected EOF while parsing

--
components: Library (Lib)
messages: 335025
nosy: blueyed
priority: normal
severity: normal
status: open
title: pdb: "debug print(" crashes with SyntaxError
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[daniel hahler]

Change by daniel hahler :


--
keywords: +patch, patch
pull_requests: +11767, 11768
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35931] pdb: "debug print(" crashes with SyntaxError

[daniel hahler]

Change by daniel hahler :


--
keywords: +patch
pull_requests: +11767
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com