[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 5e233951d931acc0e927100c51e9a27a2791b6a5 by Serhiy Storchaka 
(Miss Islington (bot)) in branch '3.7':
bpo-36150: Fix possible assertion failures due to _ctypes.c's PyCData_reduce(). 
(GH-12106) (GH-12642)
https://github.com/python/cpython/commit/5e233951d931acc0e927100c51e9a27a2791b6a5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset a110817c080ca3c2f3262350b5d7e0c0582527e6 by Serhiy Storchaka 
(Zackery Spytz) in branch '2.7':
bpo-36150: Fix possible assertion failures due to _ctypes.c's PyCData_reduce(). 
(GH-12106) (GH-12643)
https://github.com/python/cpython/commit/a110817c080ca3c2f3262350b5d7e0c0582527e6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Zackery Spytz]

Change by Zackery Spytz :


--
pull_requests: +12575

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[miss-islington]

Change by miss-islington :


--
pull_requests: +12574
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 5f2c50810a67982b0c80f6d3258fee3647f67005 by Serhiy Storchaka 
(Zackery Spytz) in branch 'master':
bpo-36150: Fix possible assertion failures due to _ctypes.c's PyCData_reduce(). 
(GH-12106)
https://github.com/python/cpython/commit/5f2c50810a67982b0c80f6d3258fee3647f67005


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution: not a bug -> 
stage: resolved -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Zackery Spytz]

Zackery Spytz  added the comment:

I again encountered an assertion failure that involved PyCData_reduce(). In 
that function, PyBytes_FromStringAndSize() may be evaluated before 
PyObject_GetAttrString(). If a MemoryError occurs in 
PyBytes_FromStringAndSize(), an assertion failure will occur in 
_PyType_Lookup() when PyObject_GetAttrString() is called.

The assertion failure occurs before the Py_BuildValue() call. Please reopen the 
issue and the PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Zackery Spytz]

Zackery Spytz  added the comment:

I'm sorry. I misunderstood the behavior of Py_BuildValue().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Christian Heimes]

Christian Heimes  added the comment:

Yes, N and O accept NULL and pass the exception up the call stack. It's not a 
bug. 
https://docs.python.org/3/c-api/arg.html?highlight=py_buildvalue#c.Py_BuildValue

--
nosy: +christian.heimes
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Does not Py_BuildValue() check the argument for "N" for NULL?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +12113
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36150] Possible assertion failures due to _ctypes.c's PyCData_reduce()

[Zackery Spytz]

New submission from Zackery Spytz :

The PyBytes_FromStringAndSize() and PyObject_GetAttrString() calls in 
PyCData_reduce() are not checked for failure.

--
components: Extension Modules, ctypes
messages: 336866
nosy: ZackerySpytz
priority: normal
severity: normal
status: open
title: Possible assertion failures due to _ctypes.c's PyCData_reduce()
type: crash
versions: Python 2.7, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com