[issue36396] Remove fgBg param of idlelib.config.GetHighlight()

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36396] Remove fgBg param of idlelib.config.GetHighlight()

[miss-islington]

miss-islington  added the comment:


New changeset 2d7798ad12456e137b3e3bc82a9824d0d3d45af0 by Miss Islington (bot) 
in branch '3.7':
bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() (GH-12491)
https://github.com/python/cpython/commit/2d7798ad12456e137b3e3bc82a9824d0d3d45af0


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36396] Remove fgBg param of idlelib.config.GetHighlight()

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset c1419578a18d787393c7ccee149e7c1fff17a99e by Terry Jan Reedy in 
branch 'master':
bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() (GH-12491)
https://github.com/python/cpython/commit/c1419578a18d787393c7ccee149e7c1fff17a99e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36396] Remove fgBg param of idlelib.config.GetHighlight()

[miss-islington]

Change by miss-islington :


--
pull_requests: +12450
stage: commit review -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36396] Remove fgBg param of idlelib.config.GetHighlight()

[Terry J. Reedy]

Terry J. Reedy  added the comment:

There were two uses in IDLE and a few in the tests.

--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36396] Remove fgBg param of idlelib.config.GetHighlight()

[Terry J. Reedy]

Change by Terry J. Reedy :


--
keywords: +patch
pull_requests: +12444
stage: commit review -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36396] Remove fgBg param of idlelib.config.GetHighlight()

[Terry J. Reedy]

New submission from Terry J. Reedy :

The fgBg param of idlelib.config.GetHighlight() is used in only one idlelib 
call.  Two other places could use it, but instead subscript the returned dict.  
Remove the parameter, make the function always return a dict and not a color, 
and have the one fgBg call use a subscript.

--
assignee: terry.reedy
components: IDLE
messages: 338580
nosy: terry.reedy
priority: normal
severity: normal
stage: commit review
status: open
title: Remove fgBg param of idlelib.config.GetHighlight()
type: enhancement
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com