[issue36440] more helpful diagnostics for parser module

[Xavier Combelle]

Change by Xavier Combelle :


--
nosy:  -xcombelle

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Since the parser module did not work in 3.7, I think this will not harm. But in 
general new features (including changes in error messages) are added only in 
the developed version.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Issue #36256 (a real bug) was backported to 3.7 but also includes a similar 
improvement regarding node names in error messages. I can revert it from 3.7 if 
you consider it should not be there.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Why was this merged in 3.7? This is a new feature, not a bug fix.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Thanks A. Skrobov for your contribution! :)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 513d142993bb8c13e6803727fa086e44eafc360f by Pablo Galindo in 
branch '3.7':
[3.7] bpo-36440: include node names in ParserError messages, instead of numeric 
IDs (GH-12565) (GH-12671)
https://github.com/python/cpython/commit/513d142993bb8c13e6803727fa086e44eafc360f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +12599
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset cb0748d3939c31168ab5d3b80e3677494497d5e3 by Pablo Galindo 
(tyomitch) in branch 'master':
bpo-36440: include node names in ParserError messages, instead of numeric IDs 
(GH-12565)
https://github.com/python/cpython/commit/cb0748d3939c31168ab5d3b80e3677494497d5e3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
versions: +Python 3.8 -Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

> Meaning that no one will ever look at it again.

I am very interested in a better alternative to the parser module, so I will 
open soon another issue for that matter. But as the original issue was about a 
specific bug, I prefer to mark it as resolved :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[A. Skrobov]

A. Skrobov  added the comment:

> Nothing was really "decided", just that meanwhile is better not to ship a 
> broken parser module.

Totally true, but the issue is closed and resolved, meaning that no one will 
ever look at it again.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Haha, you were faster creating the PR than me posting the message!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Thank you very much for creating the issue :)

> Seeing that the implicit resolution at #36256 was to keep the parser module 
> in place

Nothing was really "decided", just that meanwhile is better not to ship a 
broken parser module.

>  may I suggest that the diagnostics it produces be improved, so that instead 
> of "Expected node type 305, got 11", it would raise "Expected namedexpr_test, 
> got COLON"

Would you like to produce a PR for this?

--
stage: patch review -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[A. Skrobov]

New submission from A. Skrobov :

Seeing that the implicit resolution at #36256 was to keep the parser module in 
place, may I suggest that the diagnostics it produces be improved, so that 
instead of "Expected node type 305, got 11", it would raise "Expected 
namedexpr_test, got COLON"

--
components: Extension Modules
messages: 338897
nosy: A. Skrobov, benjamin.peterson, berker.peksag, brett.cannon, fdrake, 
gregory.p.smith, pablogsal, python-dev, serhiy.storchaka, xcombelle
priority: normal
severity: normal
status: open
title: more helpful diagnostics for parser module
type: enhancement
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36440] more helpful diagnostics for parser module

[A. Skrobov]

Change by A. Skrobov :


--
keywords: +patch
pull_requests: +12510
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com