[issue36589] Incorrect error handling in curses.update_lines_cols()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 187785e2fa2050156a6eda93fb2da31db13f07a6 by Serhiy Storchaka in 
branch '3.8':
[3.8] bpo-36589: Fix the error handling in curses.update_lines_cols(). 
(GH-12766) (GH-24023)
https://github.com/python/cpython/commit/187785e2fa2050156a6eda93fb2da31db13f07a6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36589] Incorrect error handling in curses.update_lines_cols()

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +22863
pull_request: https://github.com/python/cpython/pull/24023

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36589] Incorrect error handling in curses.update_lines_cols()

[Cheryl Sabella]

Change by Cheryl Sabella :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36589] Incorrect error handling in curses.update_lines_cols()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 2bc343417a4de83fa6998ff91303877734ecd366 by Serhiy Storchaka 
(Zackery Spytz) in branch 'master':
bpo-36589: Fix the error handling in curses.update_lines_cols(). (GH-12766)
https://github.com/python/cpython/commit/2bc343417a4de83fa6998ff91303877734ecd366


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36589] Incorrect error handling in curses.update_lines_cols()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Historically the update_lines_cols() helper returned 0 on error, and I think 
that it is better to keep it so.

The bug is in the Python function update_lines_cols() added in 3.5 (see 
issue4254). Its implementation should return NULL if the helper returns 0, and 
None otherwise. There is no reason to return an integer.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36589] Incorrect error handling in curses.update_lines_cols()

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +12694
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36589] Incorrect error handling in curses.update_lines_cols()

[Zackery Spytz]

New submission from Zackery Spytz :

update_lines_cols() returns 0 if an error occurs, but the generated AC code 
checks for a return value of -1.

--
components: Extension Modules
messages: 339881
nosy: ZackerySpytz
priority: normal
severity: normal
status: open
title: Incorrect error handling in curses.update_lines_cols()
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com