[issue36689] docs: os.path.commonpath raises ValueError for different drives

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Yes, sure

--
nosy: +asvetlov
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36689] docs: os.path.commonpath raises ValueError for different drives

[Avinash Sajjanshetty]

Avinash Sajjanshetty  added the comment:

status of issue should be closed? cos the related PR is already merged

--
nosy: +avi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36689] docs: os.path.commonpath raises ValueError for different drives

[makdon]

makdon  added the comment:

I create a PR according Windson Yang's suggestion.

--
keywords: +patch
message_count: 4.0 -> 5.0
nosy: +makdon
nosy_count: 8.0 -> 9.0
pull_requests: +13908
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14045

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36689] docs: os.path.commonpath raises ValueError for different drives

[Guido van Rossum]

Change by Guido van Rossum :


--
nosy:  -gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36689] docs: os.path.commonpath raises ValueError for different drives

[Guido van Rossum]

Guido van Rossum  added the comment:

Flagging as Windows issue.

--
components: +Windows
nosy: +gvanrossum, paul.moore, steve.dower, tim.golden, zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36689] docs: os.path.commonpath raises ValueError for different drives

[Windson Yang]

Windson Yang  added the comment:

An easy fix would be 

"Raise ValueError if paths contain (note: use contain instead of contains) both 
absolute and relative pathnames or the path are on the different drives."

--
nosy: +Windson Yang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36689] docs: os.path.commonpath raises ValueError for different drives

[Patrick Artman]

Patrick Artman  added the comment:

If this isn't taken I'd be happy to give it a go as my first contribution

--
nosy: +pjartman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36689] docs: os.path.commonpath raises ValueError for different drives

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +easy
stage:  -> needs patch
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36689] docs: os.path.commonpath raises ValueError for different drives

[Christoph Reiter]

New submission from Christoph Reiter :

Since I just got bit by this despite reading the docs:

https://docs.python.org/3.8/library/os.path.html#os.path.commonpath

It lists various error cases where ValueError is raised but is missing the case 
where absolute paths on Windows are on different drives and I forgot to handle 
that:

  File "C:/building/msys64/mingw64/lib/python3.7\ntpath.py", line 631, in 
commonpath
raise ValueError("Paths don't have the same drive")
ValueError: Paths don't have the same drive

--
assignee: docs@python
components: Documentation
messages: 340604
nosy: docs@python, lazka
priority: normal
severity: normal
status: open
title: docs: os.path.commonpath raises ValueError for different drives
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com