[issue36763] Implementation of the PEP 587

[miss-islington]

miss-islington  added the comment:


New changeset 1d4285a042772c7a31c4e19f8dbcbcf9b2ee3b95 by Miss Islington (bot) 
in branch '3.8':
bpo-36763: Make Py_BytesMain() public (GH-15532)
https://github.com/python/cpython/commit/1d4285a042772c7a31c4e19f8dbcbcf9b2ee3b95


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:

I marked the PEP 587 Status as Final. The implementation should now be 
complete. If there are bugs, they can be fixed in following issues :-) I close 
now this issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 9a943b4ce13fac26873b8100e89c818c5c47ac4b by Victor Stinner in 
branch 'master':
bpo-36763: Make Py_BytesMain() public (GH-15532)
https://github.com/python/cpython/commit/9a943b4ce13fac26873b8100e89c818c5c47ac4b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[miss-islington]

Change by miss-islington :


--
pull_requests: +15214
pull_request: https://github.com/python/cpython/pull/15535

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +15213
pull_request: https://github.com/python/cpython/pull/15532

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset af84a88ef8b3288da528d2f52b7d3fbafb8dc8a6 by Victor Stinner in 
branch '3.8':
bpo-36763: PyConfig_Read() handles PySys_AddXOption() (GH-15431) (GH-15435)
https://github.com/python/cpython/commit/af84a88ef8b3288da528d2f52b7d3fbafb8dc8a6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +15129
pull_request: https://github.com/python/cpython/pull/15435

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[miss-islington]

miss-islington  added the comment:


New changeset 9cbdce3917ab41856b61ac5c0f3c4ac0e203f320 by Miss Islington (bot) 
in branch '3.8':
bpo-36763, doc: Add links in the new C API init doc (GH-15433)
https://github.com/python/cpython/commit/9cbdce3917ab41856b61ac5c0f3c4ac0e203f320


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 120b707a6d43452e067daa55a8fdca69f9424abc by Victor Stinner in 
branch 'master':
bpo-36763: PyConfig_Read() handles PySys_AddXOption() (GH-15431)
https://github.com/python/cpython/commit/120b707a6d43452e067daa55a8fdca69f9424abc


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[miss-islington]

Change by miss-islington :


--
pull_requests: +15128
pull_request: https://github.com/python/cpython/pull/15434

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 1beb7c3de9c3d0e802e4267a11d937e8f024d661 by Victor Stinner in 
branch 'master':
bpo-36763, doc: Add links in the new C API init doc (GH-15433)
https://github.com/python/cpython/commit/1beb7c3de9c3d0e802e4267a11d937e8f024d661


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +15127
pull_request: https://github.com/python/cpython/pull/15433

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:

> The first doc should mention somewhere the new doc.

Done in PR 15433.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:

> _PySys_ReadPreInitOptions() code should be moved somewhere closer to 
> PyConfig_Read().

Done in PR 15431.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +15126
pull_request: https://github.com/python/cpython/pull/15431

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[miss-islington]

miss-islington  added the comment:


New changeset a6427cb2a279c4125dc26d468bcbb3374cdc5f41 by Miss Islington (bot) 
in branch '3.8':
bpo-36763: Implement PyWideStringList_Insert() of PEP 587 (GH-15423)
https://github.com/python/cpython/commit/a6427cb2a279c4125dc26d468bcbb3374cdc5f41


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 3842f2997fbd4dc840986aad2bb94656815e243b by Victor Stinner in 
branch 'master':
bpo-36763: Implement PyWideStringList_Insert() of PEP 587 (GH-15423)
https://github.com/python/cpython/commit/3842f2997fbd4dc840986aad2bb94656815e243b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[miss-islington]

Change by miss-islington :


--
pull_requests: +15124
pull_request: https://github.com/python/cpython/pull/15427

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +15122
pull_request: https://github.com/python/cpython/pull/15423

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[miss-islington]

miss-islington  added the comment:


New changeset 4c227e6a56a9704fe5b4e4509071796f3359f4bb by Miss Islington (bot) 
in branch '3.8':
bpo-36763: Use PyConfig_Clear() (GH-14445)
https://github.com/python/cpython/commit/4c227e6a56a9704fe5b4e4509071796f3359f4bb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[miss-islington]

Change by miss-islington :


--
pull_requests: +14341
pull_request: https://github.com/python/cpython/pull/14528

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 67310023f299b5a2fad71fca449b46d280036690 by Victor Stinner in 
branch 'master':
bpo-36763: Use PyConfig_Clear() (GH-14445)
https://github.com/python/cpython/commit/67310023f299b5a2fad71fca449b46d280036690


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:

Another minor implementation issue: calling _PyCoreConfig_Read() twice calls 
_Py_SetArgcArgv() twice, the second call override the first _Py_SetArgcArgv() 
call. IMHO it should only be called once, at the first _PyCoreConfig_Read() 
call.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[miss-islington]

miss-islington  added the comment:


New changeset 96f581cf9d2f1d7888d2fd9bb89f19f10c0477bf by Miss Islington (bot) 
in branch '3.8':
bpo-36763: Add PyConfig_SetWideStringList() (GH-1)
https://github.com/python/cpython/commit/96f581cf9d2f1d7888d2fd9bb89f19f10c0477bf


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:

About the documentation: https://docs.python.org/dev/c-api/init.html doesn't 
link to http://docs.python.org/dev/c-api/init_config.html

The first doc should mention somewhere the new doc.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 36242fd871d0f0977e720d4fae5700774bd8c09a by Victor Stinner in 
branch 'master':
bpo-36763: Add PyConfig_SetWideStringList() (GH-1)
https://github.com/python/cpython/commit/36242fd871d0f0977e720d4fae5700774bd8c09a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[miss-islington]

Change by miss-islington :


--
pull_requests: +14336
pull_request: https://github.com/python/cpython/pull/14523

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14261
pull_request: https://github.com/python/cpython/pull/14445

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14260
pull_request: https://github.com/python/cpython/pull/1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:

_PySys_ReadPreInitOptions() code should be moved somewhere closer to 
PyConfig_Read().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:

Two interesting TODO.

sysmodule.c: get_xoptions()

/* PEP432 TODO: we can reach this if xoptions is NULL in the main
*  interpreter config. When that happens, we need to properly set
 * the `xoptions` reference in the main interpreter config as well.
 *
 * For Python 3.7, we shouldn't be able to get here due to the
 * combination of how _PyMainInterpreter_ReadConfig and _PySys_EndInit
 * work, but we expect 3.8+ to make the _PyMainInterpreter_ReadConfig
 * call optional for embedding applications, thus making this
 * reachable again.
 */

sysmodule.c: get_warnoptions()

/* PEP432 TODO: we can reach this if warnoptions is NULL in the main
*  interpreter config. When that happens, we need to properly set
 * the `warnoptions` reference in the main interpreter config as well.
 *
 * For Python 3.7, we shouldn't be able to get here due to the
 * combination of how _PyMainInterpreter_ReadConfig and _PySys_EndInit
 * work, but we expect 3.8+ to make the _PyMainInterpreter_ReadConfig
 * call optional for embedding applications, thus making this
 * reachable again.
 */

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[miss-islington]

miss-islington  added the comment:


New changeset 406284173a43f5c34643133e2f132ae15a071a23 by Miss Islington (bot) 
in branch '3.8':
bpo-36763, _testembed: enable assert() in release mode (GH-13857)
https://github.com/python/cpython/commit/406284173a43f5c34643133e2f132ae15a071a23


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[miss-islington]

Change by miss-islington :


--
pull_requests: +13739
pull_request: https://github.com/python/cpython/pull/13863

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 013a18a65167725f140c0395211050ae03501b12 by Victor Stinner in 
branch 'master':
bpo-36763, _testembed: enable assert() in release mode (GH-13857)
https://github.com/python/cpython/commit/013a18a65167725f140c0395211050ae03501b12


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +13732
pull_request: https://github.com/python/cpython/pull/13857

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:

TODO: I didn't implement PyWideStringList_Insert() yet.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:

I closed the following issues which are fixed by the implementation of the PEP 
587:

* bpo-1195571
* bpo-11320
* bpo-13533
* bpo-14956
* bpo-19983
* bpo-29778
* bpo-30560
* bpo-31745
* bpo-33135
* bpo-34725
* bpo-36204

Copy of my message in bpo-19983: "This issue has been fixed by the PEP 587 in 
bpo-36763: when Py_Initialize() fails, it no longer calls abort() but only 
exit(1)."

I should maybe document this change somewhere.

In bpo-19983, I proposed a patch (init_error.patch) which changed the error 
message on initiallization error: "Python initialization error: %s\n" rather 
than "Fatal Python Error: xxx\n".

Maybe we can change that?

--

I close to leave bpo-22213 open.

bpo-32573 (missing sys.argv) is already fixed in the master branch, but I have 
been asked to also fix the issue in Python 3.7, so I wrote PR 13553.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 331a6a56e9a9c72f3e4605987fabdaec72677702 by Victor Stinner in 
branch 'master':
bpo-36763: Implement the PEP 587 (GH-13592)
https://github.com/python/cpython/commit/331a6a56e9a9c72f3e4605987fabdaec72677702


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +13499
pull_request: https://github.com/python/cpython/pull/13592

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 20e1e2582e5e69e43af88ff58699c8883d146acb by Victor Stinner in 
branch 'master':
bpo-36763: Fix _PyPreConfig_InitCompatConfig() utf8_mode (GH-13518)
https://github.com/python/cpython/commit/20e1e2582e5e69e43af88ff58699c8883d146acb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +13435

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 5edcf263581c70f6a6c2206db679e51e9418bb38 by Victor Stinner in 
branch 'master':
bpo-36763: Rename private Python initialization functions (GH-13511)
https://github.com/python/cpython/commit/5edcf263581c70f6a6c2206db679e51e9418bb38


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +13427

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 022be02dcfdfd9011415804bb4553a33fa7ec8f3 by Victor Stinner in 
branch 'master':
bpo-36763: Add _PyPreConfig._config_init (GH-13481)
https://github.com/python/cpython/commit/022be02dcfdfd9011415804bb4553a33fa7ec8f3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +13392

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 0f72147ce2b3d65235b41eddc6a57be40237b5c7 by Victor Stinner in 
branch 'master':
bpo-36763: Fix _PyRuntime.preconfig.coerce_c_locale (GH-13444)
https://github.com/python/cpython/commit/0f72147ce2b3d65235b41eddc6a57be40237b5c7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36763] Implementation of the PEP 587

[STINNER Victor]

Change by STINNER Victor :


--
title: PEP 587: Rework initialization API to prepare second version of the PEP 
-> Implementation of the PEP 587

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com