[issue36777] unittest discover throws TypeError on empty packages

[Gus Goulart]

Change by Gus Goulart :


--
keywords: +patch
pull_requests: +13169
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36777] unittest discover throws TypeError on empty packages

[Gus Goulart]

Gus Goulart  added the comment:

Confirming that the issue seems to have been introduced on 3.7. Working on this 
at the PyCon US 2019 sprints.

--
nosy: +gus.goulart

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36777] unittest discover throws TypeError on empty packages

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

I opened issue36784 for reference leak in the initial report along with a 
reproducer that is reproducible on master branch without my changes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36777] unittest discover throws TypeError on empty packages

[Karthikeyan Singaravelan]

New submission from Karthikeyan Singaravelan :

In the given folder structure unittest discover fails. I think this is due to 
issue32303 where __file__ was set as None and I guess empty packages didn't 
have __file__ set before which has None value now. Hence the_module.__file__ 
returns None and thus subsequent calls to os.path.dirname raise TypeError. 
There is one another location in the same file in unittest module causing this 
issue. See also issue36406 for similar error in doctest with the change. I 
reverted bbbcf8693b876daae4469765aa62f8924f39a7d2 just to confirm the issue. I 
am adding devs in issue32303 and unittest. Any thoughts on this would be 
helpful.

➜  cpython git:(master) ✗ tree test1
test1
└── test2
└── test_foo.py

1 directory, 1 file
➜  cpython git:(master) ✗ ./python.exe -m unittest discover test1.test2
Traceback (most recent call last):
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/runpy.py", line 
192, in _run_module_as_main
return _run_code(code, main_globals, None,
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/runpy.py", line 
85, in _run_code
exec(code, run_globals)
  File 
"/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/unittest/__main__.py", 
line 18, in 
main(module=None)
  File 
"/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/unittest/main.py", 
line 100, in __init__
self.parseArgs(argv)
  File 
"/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/unittest/main.py", 
line 124, in parseArgs
self._do_discovery(argv[2:])
  File 
"/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/unittest/main.py", 
line 244, in _do_discovery
self.createTests(from_discovery=True, Loader=Loader)
  File 
"/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/unittest/main.py", 
line 154, in createTests
self.test = loader.discover(self.start, self.pattern, self.top)
  File 
"/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/unittest/loader.py", 
line 306, in discover
os.path.dirname((the_module.__file__)))
  File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/posixpath.py", 
line 152, in dirname
p = os.fspath(p)
TypeError: expected str, bytes or os.PathLike object, not NoneType

# 3.6.4 works that doesn't have the change

➜  cpython git:(master) ✗ python3.6 -m unittest discover test1.test2
.
--
Ran 1 test in 0.000s

OK


A unittest would be as below : 

def test_empty_package_discovery(self):
# bpo-36789: Return zero test cases when using discovery in
# empty packages.

with support.temp_dir() as path:
dirname, basename = os.path.split(path)
os.mkdir(os.path.join(path, 'test2'))

with support.DirsOnSysPath(dirname):
loader = unittest.TestLoader()
empty_package = f"{basename}.test2"
tests_count = loader.discover(empty_package).countTestCases()
self.assertEqual(loader.discover(empty_package).countTestCases(), 0)


One possible fix would be to check for __file__ == None and return empty list 
of test cases but this causes a behavior change like below where my patch 
returns 0 and python 3.6 returns 1 test.

# Patch

diff --git a/Lib/unittest/loader.py b/Lib/unittest/loader.py
index ba7105e1ad..f465b2419f 100644
--- a/Lib/unittest/loader.py
+++ b/Lib/unittest/loader.py
@@ -302,6 +302,10 @@ class TestLoader(object):
 the_module = sys.modules[start_dir]
 top_part = start_dir.split('.')[0]
 try:
+filepath = the_module.__file__
+# __file__ is None for empty packages. Hence return empty 
list of tests.
+if filepath == None:
+return self.suiteClass([])
 start_dir = os.path.abspath(
os.path.dirname((the_module.__file__)))
 except AttributeError:

# Behavior change

➜  cpython git:(unittest-empty-package) ✗ ./python.exe -m unittest discover 
test1.test2

--
Ran 0 tests in 0.000s

OK
➜  cpython git:(unittest-empty-package) ✗ python3.6 -m unittest discover 
test1.test2
.
--
Ran 1 test in 0.000s

OK

My patch also causes reference leak and I am not sure why. So I guess mine is 
not the best approach to solving this.

➜  cpython git:(unittest-empty-package) ✗ ./python.exe -m test 
--fail-env-changed -R 3:3 test_unittest
Run tests sequentially
0:00:00 load avg: 1.46 [1/1] test_unittest
beginning 6 repetitions
123456
..
test_unittest leaked [99, 99, 99] references, sum=297
test_unittest leaked [38, 38, 38] memory blocks, sum=114
test_unittest failed in 43 sec 634 ms

== Tests result: FAILURE ==

1 test failed:
test_unittest

Total duration: 43 sec 655 ms
Tests result: FAILURE

--
components: Library (Lib)