[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[STINNER Victor]

STINNER Victor  added the comment:

The initial issue is fixed in 3.7 and master branches. If you want to work on 
related issue like WIN32_LEAN_AND_MEAN, please open a separated issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 791e5fcbab9e444b62d13d08707cbbbeb9406297 by Victor Stinner (Erik 
Janssens) in branch '3.7':
 bpo-36965: Fix includes in main.c on Windows with non-MSC compilers (GH-13421) 
(GH-13471)
https://github.com/python/cpython/commit/791e5fcbab9e444b62d13d08707cbbbeb9406297


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[Erik Janssens]

Change by Erik Janssens :


--
pull_requests: +13401

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[Eryk Sun]

Eryk Sun  added the comment:

>  FSCTL_GET_REPARSE_POINT is not exported with WIN32_LEAN_AND_MEAN

You can explicitly include "winioctl.h" after "windows.h". Getting it from 
"windows.h" is indirect via "winscard.h" (smart card services), which will be 
skipped if either WIN32_LEAN_AND_MEAN or NOCRYPT is defined.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[STINNER Victor]

STINNER Victor  added the comment:

> WIN32_LEAN_AND_MEAN is defined by Include/internal/pycore_condvar.h (...)

It would be nice to get ride of #include  in Python headers. The 
 was introduced by this commit:

commit 2ebc5ce42a8a9e047e790aefbf9a94811569b2b6
Author: Eric Snow 
Date:   Thu Sep 7 23:51:28 2017 -0600

bpo-30860: Consolidate stateful runtime globals. (#3397)

* group the (stateful) runtime globals into various topical structs
* consolidate the topical structs under a single top-level _PyRuntimeState 
struct
* add a check-c-globals.py script that helps identify runtime globals

Other globals are excluded (see globals.txt and check-c-globals.py).

The current problem is that we need the HANDLE type which comes from 
 to get the full structure:

typedef struct _PyCOND_T
{
HANDLE sem;
int waiting; /* to allow PyCOND_SIGNAL to be a no-op */
} PyCOND_T;

I tried to avoid "HANDLE" using:

typedef struct _PyCOND_T
{
void* sem;
int waiting; /* to allow PyCOND_SIGNAL to be a no-op */
} PyCOND_T;

... but then pycore_condvar.h compilation fails on "typedef CRITICAL_SECTION 
PyMUTEX_T;": CRITICAL_SECTION type is not defined :-(

By the way, Python still uses _PY_EMULATED_WIN_CV by default, whereas we want 
to drop Vista support: bpo-32592.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[STINNER Victor]

STINNER Victor  added the comment:

eryksun commented there, but I prefer to discuss here:
https://github.com/python/cpython/commit/925af1d99b69bf3e229411022ad840c5a0cfdcf8#commitcomment-33617265

""Windows.h" was already being included, as I mentioned on the issue tracker, 
because we certainly were not getting STATUS_CONTROL_C_EXIT from "crtdbg.h", a 
header that was left in this file accidentally about 12 years ago. If it's 
included explicitly here, also define WIN32_LEAN_AND_MEAN to cut the number of 
included headers by about a half."

I prefer to explicitly include windows.h, it doesn't hurt :-)

WIN32_LEAN_AND_MEAN is defined by Include/internal/pycore_condvar.h which is 
indirectly included by pycore_pystate.h:

#include "pycore_gil.h"   /* _gil_runtime_state  */

pycore_gil.h:

#include "pycore_condvar.h"


By the way, WIN32_LEAN_AND_MEAN caused me issues while working on bpo-36728:
https://twitter.com/VictorStinner/status/1127884878027079680

I managed to workaround the issue: commit 
d5d9e81ce9a7efc5bc14a5c21398d1ef6f626884

Extract of (fixed) posixmodule.c:
---
...
#include "Python.h"
#ifdef MS_WINDOWS
   /* include  early to avoid conflict with pycore_condvar.h:

#define WIN32_LEAN_AND_MEAN
#include 

  FSCTL_GET_REPARSE_POINT is not exported with WIN32_LEAN_AND_MEAN. */
#  include 
#endif

#include "pycore_ceval.h" /* _PyEval_ReInitThreads() */
#include "pycore_pystate.h"   /* _PyRuntime */
...
---

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 925af1d99b69bf3e229411022ad840c5a0cfdcf8 by Victor Stinner (Erik 
Janssens) in branch 'master':
bpo-36965: Fix includes in main.c on Windows with non-MSC compilers (GH-13421)
https://github.com/python/cpython/commit/925af1d99b69bf3e229411022ad840c5a0cfdcf8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[Eryk Sun]

Eryk Sun  added the comment:

"crtdbg.h" doesn't provide STATUS_CONTROL_C_EXIT, but it should be fine to 
remove it anyway. I think it was left behind by accident in 2007. It was added 
to support a PYTHONNOERRORWINDOW environment variable, but then this idea was 
dropped in favor of extending the msvcrt module:

* https://grokbase.com/t/python/python-3000/078wkax0sd/buildbots
* 
https://github.com/python/cpython/commit/945362cf971fb2e10f8f2a8e71e8ff10516ebe4c#diff-75445bdc3b6b3dd20b005698fa165444
* 
https://github.com/python/cpython/commit/3dc33d18452de871cff98914dda81ff00b4d00f6#diff-75445bdc3b6b3dd20b005698fa165444

I presume STATUS_CONTROL_C_EXIT gets included from "winnt.h" -> "Windows.h" -> 
"Include/internal/pycore_condvar.h" -> "Include/internal/pycore_gil.h" -> 
"Include/internal/pycore_pystate.h".

If [STATUS_]CONTROL_C_EXIT isn't defined, I suggest defining 
WIN32_LEAN_AND_MEAN before including "Windows.h". This reduces the number of 
included headers from about 350 down to about 200. Also, to stay strictly 
within the Windows API, we might want to use CONTROL_C_EXIT (from 
[min]winbase.h) instead of STATUS_CONTROL_C_EXIT (from "winnt.h").

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[Erik Janssens]

Erik Janssens  added the comment:

PR has been changed to include "windows.h" ...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[Erik Janssens]

Erik Janssens  added the comment:

ok, thank you for the advice, I'll keep it in mind and adapt the PR !

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[Steve Dower]

Steve Dower  added the comment:

Some people say "windows.h" is the only one you're ever supposed to include, so 
if that works best, let's go with that :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[Erik Janssens]

Erik Janssens  added the comment:

including "winnt.h" gives me compilation problems with other undefined types.

however, simply including "windows.h" instead of both includes compiles just 
fine.

so maybe that is sufficient ??

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[Steve Dower]

Steve Dower  added the comment:

Is including just "winnt.h" sufficient?

It's very hard to tell which Windows headers are "public" vs "internal", but 
winternl.h is certainly one of the internal ones (according to the big warning 
comment at the top of the file)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[Erik Janssens]

Erik Janssens  added the comment:

According to the Microsoft documentation at

https://docs.microsoft.com/en-us/windows-hardware/drivers/kernel/using-ntstatus-values

system-supplied status codes are defined in ntstatus.h. and the NTSTATUS type 
is defined in ntdef.h

PR 13421 includes both ntstatus.h and ntdef.h to be able to use 
STATUS_CONTROL_C_EXIT when compiling for windows.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[Erik Janssens]

Change by Erik Janssens :


--
keywords: +patch
pull_requests: +13330
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[SilentGhost]

Change by SilentGhost :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36965] use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with non MSC compilers

[Erik Janssens]

New submission from Erik Janssens :

in Modules/main.c STATUS_CONTROL_C_EXIT is included conditionally if compiling 
when _MSC_VER is defined.  Later on STATUS_CONTROL_C_EXIT is used if MS_WINDOWS 
is defined.

This breaks compilation of main.c with any non MSC compiler while compiling for 
MS Windows.

This appears to have been introduced in GH-12123 for bpo-36142

--
components: Windows
messages: 342845
nosy: erikjanss, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: use of STATUS_CONTROL_C_EXIT in Modules/main.c breaks compilation with 
non MSC compilers
type: compile error
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com