[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Committed in r66269.

--
priority: deferred blocker -> high
title: py3k aborts if "-c" or "-m" is given a non-ascii value -> py3k fails 
under Windows if "-c" or "-m" is given a non-ascii value
type: crash -> behavior

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

This patch corrects the "-m" case on windows: the path has to be
decoded/recoded using the filesystem encoding, and not the default utf-8.
Review is needed, of course.

--
nosy: +amaury.forgeotdarc
Added file: http://bugs.python.org/file11411/find_module_unicode.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Looks good and works under Linux.
One small nit, you could just as well use "NN(ssi)" for the
Py_BuildValue and remove Py_DECREF(fob), so as to be more consistent.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Updated patch.

Added file: http://bugs.python.org/file11422/find_module_unicode_2.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

./python -c "print('à')"
does not work on my Linux machine with latest py3k (r66303), certainly
because my terminal uses a latin-1 encoding: wcstombs will convert the
argument back to the terminal encoding, whereas PyRun_SimpleString
expects a UTF-8 string.

I join another patch, which propagates the wchar_t as far as possible,
and encodes it as utf-8; with test.

This also corrects the Windows case.

Added file: http://bugs.python.org/file11424/command_unicode.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

I think the patch good; go ahead.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Applied both patches as r66331.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Unfortunately, my patch does not work: see the compile warnings in "main.c":
http://www.python.org/dev/buildbot/3.0/x86%20osx.5%203.0/builds/344/step-compile/0

I reverted the change, and will try something else...

--
resolution: fixed -> 
status: closed -> open

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Today I learned something: wchar_t can be 2 or 4 bytes, PyUNICODE can be 
2 or 4 bytes, and all combinations are possible.
My error was to use PyUnicode_FromUnicode on a wchar_t*; PyUnicode_FromWideChar 
is the obvious function to use.

Attached a new patch (command_unicode_2.patch) for review.

--
keywords: +needs review
priority: high -> critical
Added file: http://bugs.python.org/file11545/command_unicode_2.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Raising to release blocker, just to trigger another review...

--
priority: critical -> release blocker

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

Go ahead.

--
keywords:  -needs review

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Fixed as r67190. Thanks for the review.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[ossdev]

Change by ossdev :


--
pull_requests: +11033

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[ossdev]

Change by ossdev :


--
pull_requests: +11033, 11034, 11035

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3705] py3k fails under Windows if "-c" or "-m" is given a non-ascii value

[ossdev]

Change by ossdev :


--
pull_requests: +11033, 11034

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com