[issue37191] Python.h contains intermingled declarations

[STINNER Victor]

STINNER Victor  added the comment:

Petr Viktorin fixed the issue, thanks ;-)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 9689f80e61e5863668a562793ebb85031ef9fd3e by Victor Stinner (Petr 
Viktorin) in branch '3.8':
bpo-37191: Avoid declaration-after-statement in header included from Python.h 
(GH-13887)
https://github.com/python/cpython/commit/9689f80e61e5863668a562793ebb85031ef9fd3e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[miss-islington]

miss-islington  added the comment:


New changeset 5effd10bf14ab0a8a6695100aaf0b687eca68e6d by Miss Islington (bot) 
in branch '3.8':
bpo-37191: Move TestPEP590 from test_capi to test_call (GH-13892)
https://github.com/python/cpython/commit/5effd10bf14ab0a8a6695100aaf0b687eca68e6d


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[STINNER Victor]

STINNER Victor  added the comment:

> I've removed -Wdeclaration-after-statement in upstream pygobject: 
> https://gitlab.gnome.org/GNOME/pygobject/merge_requests/119

Thanks! Enjoy C99! :-) IMHO C99 with variables in the middle of a function 
helps to write more reliable code: we better control the scope of a variable. 
It reduces the risk of using an uninitialized variable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[miss-islington]

Change by miss-islington :


--
pull_requests: +13772
pull_request: https://github.com/python/cpython/pull/13897

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 740a84de73ad8d02655de0a084036f4b7e49a01b by Victor Stinner in 
branch 'master':
bpo-37191: Move TestPEP590 from test_capi to test_call (GH-13892)
https://github.com/python/cpython/commit/740a84de73ad8d02655de0a084036f4b7e49a01b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[Christoph Reiter]

Christoph Reiter  added the comment:

I've removed -Wdeclaration-after-statement in upstream pygobject: 
https://gitlab.gnome.org/GNOME/pygobject/merge_requests/119

--
nosy: +lazka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +13766
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/13892

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> It's well within our rights to ignore this: since 3.6 we require intermingled 
> declarations.

It's not clear from PEP 7 if we require intermingled declarations only when 
compiling CPython itself, or also for external packages that include CPython 
headers. It would be prudent to stay C89-compatible for non-internal header 
files.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

Should we revert these inline functions back to macros?

--
nosy: +jdemeyer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[STINNER Victor]

STINNER Victor  added the comment:

PR 13887 is fine but I would prefer to still be able to use C99 style for 
variable declarations. More generally, I don't think that variable declaration 
is the only issue: static inline function is a new shiny thing which can cause 
other issues with some C compilers. So I propose a different approach, 
bpo-37194: "Move new vector private declarations to the internal C API".

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[Petr Viktorin]

Petr Viktorin  added the comment:

> pygobject3, python-dbus, xen

Correction:
- The Fedora packages failed to build; this might or might not be due to the 
projects themseves
- pygobject3 actually only warns on this

Anyway, we can usually take care of open-source stuff. Only take it as a litmus 
test for codebases we don't know about.

--
stage: patch review -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[Petr Viktorin]

Change by Petr Viktorin :


--
keywords: +patch
pull_requests: +13761
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/13887

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37191] Python.h contains intermingled declarations

[Petr Viktorin]

New submission from Petr Viktorin :

When compiled with GCC's -Werror=declaration-after-statement ("intermingled 
declarations" in PEP7), cpython/abstract.h (included from ) errors on 
vectorcall helper functions added in 3.8.0 Beta 1.

It's well within our rights to ignore this: since 3.6 we require intermingled 
declarations.
But, when re-compiling Fedora we've seen several projects fail with this 
warning (so far: pygobject3, python-dbus, xen; more will likely come).

Dear Release Manager, should we patch 3.8 to avoid this? The patch is simple, 
and it would give projects that we(re) dutifully tested with the Alphas one 
more release to adapt.

I don't think it's worth changing for 3.9 (but if we do we should test it).

--
messages: 344912
nosy: lukasz.langa, petr.viktorin
priority: normal
severity: normal
status: open
title: Python.h contains intermingled declarations
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com