[issue3723] Py_NewInterpreter does not work
Christian Heimes [EMAIL PROTECTED] added the comment: Applied in r67057 -- resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Graham Dumpleton [EMAIL PROTECTED] added the comment: In conjunction with #4213, the attached subinterpreter.patch appears to fix issue for mod_wsgi. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Christian Heimes [EMAIL PROTECTED] added the comment: In combination with the patch in #4213, subinterpreter.patch fixes the problem. I'm assigning the bug to Barry for his final decision. -- assignee: - barry nosy: +barry type: - behavior ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Changes by Christian Heimes [EMAIL PROTECTED]: -- dependencies: +Lower case file system encoding ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Christian Heimes [EMAIL PROTECTED] added the comment: The patch subinterpreter.patch is based on Martin's patch importexc.diff. The patch contains additional code to setup a preliminary stderr object and a call to initstdio(). Amaury is right. I had to add initstdio() to initialize the standard streams. But I can't get it to work. $ rm -f Demo/embed/importexc.o; cd Demo/embed; make; ./importexc; cd ../.. gcc -g -I../../Include -I../.. -c -o importexc.o importexc.c gcc -Xlinker -export-dynamic importexc.o ../../libpython3.0.a -lnsl -ldl -lreadline -ltermcap -lieee -lpthread -lutil -lm -o importexc Initialize interpreter module 'types' from '/usr/local/lib/python3.0/types.py' Initialize subinterpreter Fatal Python error: Py_Initialize: can't initialize sys standard streams Traceback (most recent call last): File /usr/local/lib/python3.0/encodings/__init__.py, line 32, in module ValueError: Cannot encode path item Aborted Added file: http://bugs.python.org/file11895/subinterpreter.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Martin v. Löwis [EMAIL PROTECTED] added the comment: Here is a patch that fixed importexc.c. It consists of the following parts: - set m_size of the builtins module and the sys module to -1, indicating that these modules don't support repeated initialization. This should be reviewed; perhaps it's better (and necessary) to record the init function not only for dynamically-loaded modules in m_init, but also for statically linked ones, so that the reinit code can call them again (whether or not it is safe to call them again for sys and builtins should then be studied). - add a field to the interpreter state indicating that the codecs are not ready. when trying to use the file system encoding in this state, use ASCII instead. - Fix importexc to use the types module. Added file: http://bugs.python.org/file11820/importexc.diff ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment: I think the patch goes in the right direction. But in addition, Py_NewInterpreter() has to call initstdio() between initmain() and initsite() (the same sequence as in Py_InitializeEx) Found by using the following command string in importexc.c: import types; print(types.XXX) ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Benjamin Peterson [EMAIL PROTECTED] added the comment: Wouldn't it make more sense to move interpreter initialization things to Py_NewInterpreter and call it from Py_InitializeEx? ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Christian Heimes [EMAIL PROTECTED] added the comment: Sounds like a good plan, Benjamin -- nosy: +christian.heimes ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Martin v. Löwis [EMAIL PROTECTED] added the comment: Wouldn't it make more sense to move interpreter initialization things to Py_NewInterpreter and call it from Py_InitializeEx? Can you propose a specific patch? I'm worried that doing so blindly introduces other bugs. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Changes by Barry A. Warsaw [EMAIL PROTECTED]: -- priority: deferred blocker - release blocker ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Graham Dumpleton [EMAIL PROTECTED] added the comment: Adding the functions as initfunc in module init table is of no use as they aren't invoked when creating a sub interpreter. One thing that does appear to work, although no idea of whether it is correct way to solve problem, is to duplicate the builtin/sys initialisation that occurs in Py_InitializeEx() function. Attached diff shows nature of changes. Diff is bit messy as have left existing code in there but #ifdef'd out. Maybe this will give someone who knows how overall interpreter initialisation is supposed to work a head start on coming up with proper fix. But then it could be totally wrong as well. At least with change as is, mod_wsgi works for sub interpreters now. I'll do more work later on whether it is correct way to solve it. -- nosy: +grahamd Added file: http://bugs.python.org/file11660/pythonrun.c.diff ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment: Your patch may go in the right direction, but please provide only context diff or unified diff files. Use diff -du, or svn diff to generate the file. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Graham Dumpleton [EMAIL PROTECTED] added the comment: Argh. Personally I like to provide context diff's but more often than not get abused for providing them over a unified diff. Was in a hurry this time as had only a couple of minutes of battery life left on the laptop, so quickly did it without thinking and then ran off to find a power point. :-) ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Changes by Graham Dumpleton [EMAIL PROTECTED]: Removed file: http://bugs.python.org/file11660/pythonrun.c.diff ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Graham Dumpleton [EMAIL PROTECTED] added the comment: Unified diff now attached. Added file: http://bugs.python.org/file11661/pythonrun.c.diff ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Changes by Barry A. Warsaw [EMAIL PROTECTED]: -- priority: release blocker - deferred blocker ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Changes by djc [EMAIL PROTECTED]: -- nosy: +djc ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Changes by Benjamin Peterson [EMAIL PROTECTED]: -- keywords: +needs review ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment: I applied the patch to PC/config.c, but this did not change anything. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Benjamin Peterson [EMAIL PROTECTED] added the comment: Interesting, here it lets import.c's init_builtin reinitalize modules... ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Benjamin Peterson [EMAIL PROTECTED] added the comment: Maybe, I'm not seeing the whole problem, but can't we just add _PySys_Init and _PyBuiltin_Init to config.c like in the attached patch? Obviously, we will eventually want to make a separate state to store module globals in, but I think this will work for 3.0 final. -- keywords: +patch nosy: +benjamin.peterson Added file: http://bugs.python.org/file11524/add_init_funcs.patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Changes by Barry A. Warsaw [EMAIL PROTECTED]: -- priority: deferred blocker - release blocker ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
Changes by Benjamin Peterson [EMAIL PROTECTED]: -- priority: release blocker - deferred blocker ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3723] Py_NewInterpreter does not work
New submission from Amaury Forgeot d'Arc [EMAIL PROTECTED]: The example Demo/embed/importexc.c crashes, because Py_NewInterpreter cannot reimport builtins and sys modules. This problem seems important for embedding applications like mod_python, for example. (the import exceptions statement does not work with python 3.0, but replacing with e.g. import types does not change anything: the interpreter is not correctly renewed) I tried to put -1 in the m_size structure of these modules, and they seem to import correctly. However, builtins comes with its original dictionary - without the standard exceptions. I think that these modules should be made re-importable, with specific functions. Maybe two related problems: - once you've done del sys.modules['sys'] it's not possible to get it back, import sys raises an error... - the usual trick to call sys.setdefaultencoding will not work, since it needs to imp.reload(sys) -- components: Extension Modules messages: 72127 nosy: amaury.forgeotdarc, loewis priority: release blocker severity: normal status: open title: Py_NewInterpreter does not work versions: Python 3.0 ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3723 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
