[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

[miss-islington]

miss-islington  added the comment:


New changeset f9919121460bffc04f935dbdb85f0af3ffbd3ddf by Miss Islington (bot) 
in branch '3.8':
bpo-37256: Wording in Request class docs (GH-14792)
https://github.com/python/cpython/commit/f9919121460bffc04f935dbdb85f0af3ffbd3ddf


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

[Senthil Kumaran]

Senthil Kumaran  added the comment:

Thank you for the patch, CuriousLearner.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

[miss-islington]

miss-islington  added the comment:


New changeset 3e1f135b26cf5fb3583d7e75d39b7b7a9edb472c by Miss Islington (bot) 
in branch '3.7':
bpo-37256: Wording in Request class docs (GH-14792)
https://github.com/python/cpython/commit/3e1f135b26cf5fb3583d7e75d39b7b7a9edb472c


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

[miss-islington]

Change by miss-islington :


--
pull_requests: +15000
pull_request: https://github.com/python/cpython/pull/15277

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

[miss-islington]

Change by miss-islington :


--
pull_requests: +15001
pull_request: https://github.com/python/cpython/pull/15278

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

[Senthil Kumaran]

Senthil Kumaran  added the comment:


New changeset 38c7199beb30ae9a5005c0f0d9df9fae0da3680a by Senthil Kumaran 
(Ngalim Siregar) in branch 'master':
bpo-37256: Wording in Request class docs (#14792)
https://github.com/python/cpython/commit/38c7199beb30ae9a5005c0f0d9df9fae0da3680a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Thanks for the bug report Alan & for the PR Ngalim!

I've checked the current docs and this is a valid bug.

I've also reviewed the Pull request and it looks good to me.

@Mariatta, @Senthil can you please have a look at this?

Many thanks!

--
nosy: +CuriousLearner, Mariatta, orsenthil
versions:  -Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

[Ngalim Siregar]

Change by Ngalim Siregar :


--
keywords: +patch
pull_requests: +14587
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/14792

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

[Alan De Smet]

Alan De Smet  added the comment:

Oops, used to GitHub/GitLab, where Markdown is fair game. Sorry about that. :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

[Alan De Smet]

New submission from Alan De Smet :

In Doc/library/urllib.request.rst, in the documentation for the class 
`Request`, it says

```
   The final two arguments are only of interest for correct handling
   of third-party HTTP cookies:
```

However, three arguments follow, not two, and the last is not necessarily 
related to third-party cookie handling.

I believe replacing "final" with "next" will correct the sentence:

```
   The next two arguments are only of interest for correct handling
   of third-party HTTP cookies:
```

Verified present in the source releases for CPython 3.5.7, 3.6.8, 3.7.3, 
3.8.0b1. It is _not_ present in 2.7.16 (as the third parameter didn't yet 
exist, so the existing phrasing is correct.)

--
assignee: docs@python
components: Documentation
messages: 345403
nosy: Alan De Smet, docs@python
priority: normal
severity: normal
status: open
title: urllib.request.Request documentation erroneously refers to the "final 
two"
type: enhancement
versions: Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com