[issue37752] Redundant Py_CHARMASK called in some files

[Steve Dower]

Steve Dower  added the comment:

Thanks for the patch!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in some files

[Steve Dower]

Steve Dower  added the comment:


New changeset 2ec70102066fe5534f1a62e8f496d2005e1697db by Steve Dower (Jordon 
Xu) in branch 'master':
bpo-37752: Delete redundant Py_CHARMASK in normalizestring() (GH-15095)
https://github.com/python/cpython/commit/2ec70102066fe5534f1a62e8f496d2005e1697db


--
nosy: +steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in some files

[hai shi]

hai shi  added the comment:

typo error: delte->delete

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in some files

[hai shi]

hai shi  added the comment:

Due to this macro documented in 
https://docs.python.org/3.9/c-api/intro.html#c.Py_CHARMASK and we don't know 
how much user use this marco, I don't think we need delte this 
function(deleting operation should be careful).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in some files

[Jordon.X]

Jordon.X <9651...@qq.com> added the comment:

Hi Ma, 
I think this is a very valuable suggestion.
And if we want to delete the definition of Py_CHARMASK, maybe another issue 
needed.
I am not very sure about the considerations of this macro definition. And 
whether there are any side effects after deletion needs further discussion.

Thanks,
Best Regards

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in some files

[Ma Lin]

Ma Lin  added the comment:

VC2017 optimizes multiple `unsigned char)((c) & 0xff` to a single `movzx` 
operation, maybe other compilers do it as well.
If so, there will be no performance changes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37752] Redundant Py_CHARMASK called in some files

[Jordon.X]

Jordon.X <9651...@qq.com> added the comment:

After the full search for the project code, there are more than a dozen similar 
issues that need to be modified. A new PR will be added later.

--
title: Redundant Py_CHARMASK called in normalizestring(codecs.c) -> Redundant 
Py_CHARMASK called in some files

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com