[issue37804] Remove Thread.isAlive in Python 3.9

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 9825bdfbd5c966abf1f1b7264992d722a94c9613 by Jelle Zijlstra in 
branch 'master':
bpo-43723: Deprecate camelCase aliases from threading (GH-25174)
https://github.com/python/cpython/commit/9825bdfbd5c966abf1f1b7264992d722a94c9613


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37804] Remove Thread.isAlive in Python 3.9

[Jelle Zijlstra]

Change by Jelle Zijlstra :


--
pull_requests: +23916
pull_request: https://github.com/python/cpython/pull/25174

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37804] Remove Thread.isAlive in Python 3.9

[STINNER Victor]

STINNER Victor  added the comment:

> we should probably also deprecate the setter/getter methods that you mention

You can deprecate them. Please open a new issue for that, this one is closed 
and specific to Thread.isAlive.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37804] Remove Thread.isAlive in Python 3.9

[Jelle Zijlstra]

Jelle Zijlstra  added the comment:

Sure, I can submit a PR. While we're at it, we should probably also deprecate 
the setter/getter methods that you mention.

Here's what I propose doing:
- On 3.10 (or 3.11 if it's too late for 3.10), make getName and friends throw a 
DeprecationWarning, scheduling them for removal in 3.12 or 3.13
- On 3.8 and lower, update the docs to explicitly call out the names of the 
deprecated methods
- On 3.9 and higher, update the docs similarly but mention that 
threading.isAlive was already removed

If there's no objection, I'll open separate issues and PRs for these in a few 
days.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37804] Remove Thread.isAlive in Python 3.9

[STINNER Victor]

STINNER Victor  added the comment:

> The threading documentation for 3.9 still claims "While they are not listed 
> below, the camelCase names used for some methods and functions in this module 
> in the Python 2.x series are still supported by this module." It would be 
> better to mention when isAlive was removed.

Do you want to propose a PR for that?

I see still 4 camelCase methods in threading.Thread:

* 'getName' => Thread.name can be get
* 'setName' => Thread.name can be set
* 'isDaemon' => Thread.name can be get
* 'setDaemon' => Thread.daemon can be set

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37804] Remove Thread.isAlive in Python 3.9

[Jelle Zijlstra]

Jelle Zijlstra  added the comment:

The threading documentation for 3.9 still claims "While they are not listed 
below, the camelCase names used for some methods and functions in this module 
in the Python 2.x series are still supported by this module." It would be 
better to mention when isAlive was removed.

The method is still used in some major libraries, like NLTK 
(https://github.com/nltk/nltk/blob/637af5380d6071517a5f0d224649e5c3560b5f91/nltk/inference/api.py#L536).
 Documenting the removal clearly in the threading docs would make it easier for 
developers to upgrade.

--
nosy: +Jelle Zijlstra

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37804] Remove Thread.isAlive in Python 3.9

[STINNER Victor]

Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37804] Remove Thread.isAlive in Python 3.9

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 44046fe4fc7f00a6eb855b33e6a3f953cf5233a5 by Victor Stinner 
(Dong-hee Na) in branch 'master':
bpo-37804: Remove the deprecated method threading.Thread.isAlive() (GH-15225)
https://github.com/python/cpython/commit/44046fe4fc7f00a6eb855b33e6a3f953cf5233a5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37804] Remove Thread.isAlive in Python 3.9

[Dong-hee Na]

Change by Dong-hee Na :


--
keywords: +patch
pull_requests: +14949
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15225

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37804] Remove Thread.isAlive in Python 3.9

[STINNER Victor]

Change by STINNER Victor :


--
title: Remove Thread.isAlive in Python 3.8 -> Remove Thread.isAlive in Python 
3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com