[issue37872] Move _Py_IDENTIFIER statics in Python/import.c to top of the file

[Greg Price]

Change by Greg Price :


--
title: Move statics in Python/import.c to top of the file -> Move 
_Py_IDENTIFIER statics in Python/import.c to top of the file

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37872] Move _Py_IDENTIFIER statics in Python/import.c to top of the file

[Greg Price]

Change by Greg Price :


--
components: +Interpreter Core

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37872] Move _Py_IDENTIFIER statics in Python/import.c to top of the file

[STINNER Victor]

STINNER Victor  added the comment:

Why should we move static variables as globals? What is the rationale?

_Py_IDENTIFIER uses a linked list internally to be able to free all these 
strings at Python exit.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37872] Move _Py_IDENTIFIER statics in Python/import.c to top of the file

[Eric Snow]

Eric Snow  added the comment:

Yeah, I'm fine with dropping this.  In the file we have some global and some 
local, so my suggestion was to consolidate a little.  However, it mostly 
doesn't matter. :)

--
resolution:  -> rejected
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com