[issue37879] Segfaults in C heap type subclasses

[Petr Viktorin]

Petr Viktorin  added the comment:

Thanks to Stéphane and Eddie for fixing the refleak!

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37879] Segfaults in C heap type subclasses

[STINNER Victor]

STINNER Victor  added the comment:

I reopen the issue: the change caused a regression on the Refleak buildbot 
workers: bpo-38150.

--
nosy: +vstinner
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37879] Segfaults in C heap type subclasses

[Petr Viktorin]

Change by Petr Viktorin :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37879] Segfaults in C heap type subclasses

[Petr Viktorin]

Petr Viktorin  added the comment:


New changeset 3562ae25402aad36583bc27d4d82c67554323d5e by Petr Viktorin in 
branch '3.8':
[3.8] bpo-37879: Suppress subtype_dealloc decref when base type is a C heap 
type (GH-15323, GH-16004) (GH-15966)
https://github.com/python/cpython/commit/3562ae25402aad36583bc27d4d82c67554323d5e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37879] Segfaults in C heap type subclasses

[Petr Viktorin]

Petr Viktorin  added the comment:


New changeset 5e9caeec76119a0d61c25f1466c27b7dbd5115bd by Petr Viktorin in 
branch 'master':
bpo-37879: Fix warnings in _testcapimodule (GH-16004)
https://github.com/python/cpython/commit/5e9caeec76119a0d61c25f1466c27b7dbd5115bd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37879] Segfaults in C heap type subclasses

[Petr Viktorin]

Change by Petr Viktorin :


--
pull_requests: +15629
pull_request: https://github.com/python/cpython/pull/16004

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37879] Segfaults in C heap type subclasses

[Petr Viktorin]

Change by Petr Viktorin :


--
pull_requests: +15599
pull_request: https://github.com/python/cpython/pull/15966

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37879] Segfaults in C heap type subclasses

[Petr Viktorin]

Petr Viktorin  added the comment:


New changeset ff023ed36ea260ab64be5895f1f1f087c798987a by Petr Viktorin (Eddie 
Elizondo) in branch 'master':
bpo-37879: Suppress subtype_dealloc decref when base type is a C heap type 
(GH-15323)
https://github.com/python/cpython/commit/ff023ed36ea260ab64be5895f1f1f087c798987a


--
nosy: +petr.viktorin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37879] Segfaults in C heap type subclasses

[Eddie Elizondo]

Change by Eddie Elizondo :


--
keywords: +patch
pull_requests: +15040
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15323

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37879] Segfaults in C heap type subclasses

[Eddie Elizondo]

New submission from Eddie Elizondo :

`subtype_dealloc` is not correctly handling the reference count of c heap type 
subclasses. It has some builtin assumptions which can result in the type 
getting its reference count decreased more that it needs to be, leading to its 
destruction when it should still be alive.

Also, this bug is a blocker for the full adoption of PEP384.

The full details of the bug along with a fix and tests are described in the 
Github PR.

--
messages: 349905
nosy: eelizondo
priority: normal
severity: normal
status: open
title: Segfaults in C heap type subclasses

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com