[issue37929] IDLE: OK sometimes fails to close configdialog

[Tal Einat]

Tal Einat  added the comment:

Fixed.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37929] IDLE: OK sometimes fails to close configdialog

[miss-islington]

miss-islington  added the comment:


New changeset e266d062e017b122b9741db2bd5fb99742378623 by Miss Islington (bot) 
in branch '3.8':
bpo-37929: IDLE: avoid Squeezer-related config dialog crashes (GH-15452)
https://github.com/python/cpython/commit/e266d062e017b122b9741db2bd5fb99742378623


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37929] IDLE: OK sometimes fails to close configdialog

[miss-islington]

miss-islington  added the comment:


New changeset f2b468dd6d0bdbe2e87c0ca7515800a115e95e54 by Miss Islington (bot) 
in branch '3.7':
bpo-37929: IDLE: avoid Squeezer-related config dialog crashes (GH-15452)
https://github.com/python/cpython/commit/f2b468dd6d0bdbe2e87c0ca7515800a115e95e54


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37929] IDLE: OK sometimes fails to close configdialog

[miss-islington]

Change by miss-islington :


--
pull_requests: +15172
pull_request: https://github.com/python/cpython/pull/15485

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37929] IDLE: OK sometimes fails to close configdialog

[miss-islington]

Change by miss-islington :


--
pull_requests: +15171
pull_request: https://github.com/python/cpython/pull/15484

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37929] IDLE: OK sometimes fails to close configdialog

[Tal Einat]

Tal Einat  added the comment:


New changeset d4b4c00b57d24f6ee2cf3a96213406bb09953df3 by Tal Einat in branch 
'master':
bpo-37929: IDLE: avoid Squeezer-related config dialog crashes (GH-15452)
https://github.com/python/cpython/commit/d4b4c00b57d24f6ee2cf3a96213406bb09953df3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37929] IDLE: OK sometimes fails to close configdialog

[Tal Einat]

Tal Einat  added the comment:

See PR GH-15452 with a fix.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37929] IDLE: OK sometimes fails to close configdialog

[Tal Einat]

Change by Tal Einat :


--
keywords: +patch
pull_requests: +15144
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15452

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37929] IDLE: OK sometimes fails to close configdialog

[Terry J. Reedy]

New submission from Terry J. Reedy :

If one opens configdialog when there is no Shell and then hits OK, the dialog 
fails to close.  The following Squeezer-related traceback appears in associated 
console when there is one.

Exception in Tkinter callback
Traceback (most recent call last):
  File "F:\dev\3x\lib\tkinter\__init__.py", line 1885, in __call__
return self.func(*args)
  File "F:\dev\3x\lib\idlelib\configdialog.py", line 172, in ok
self.apply()
  File "F:\dev\3x\lib\idlelib\configdialog.py", line 186, in apply
self.activate_config_changes()
  File "F:\dev\3x\lib\idlelib\configdialog.py", line 240, in 
activate_config_changes
klass.reload()
  File "F:\dev\3x\lib\idlelib\squeezer.py", line 222, in reload
instance.load_font()
  File "F:\dev\3x\lib\idlelib\squeezer.py", line 318, in load_font
Font(text, font=text.cget('font')).measure('0')
  File "F:\dev\3x\lib\idlelib\delegator.py", line 10, in __getattr__
attr = getattr(self.delegate, name) # May raise AttributeError
AttributeError: 'NoneType' object has no attribute 'cget'

Either the squeezer instance should be destroyed and removed along with Shell 
or, if keeping it is intentional, it should be removed from the update list and 
reinstated or if not doing that is intentional, it must either check 'if text 
is not None' before the access or catch the attribute error after.  Tal, which?

--
assignee: terry.reedy
components: IDLE
messages: 350281
nosy: taleinat, terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE: OK sometimes fails to close configdialog
type: behavior
versions: Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com