[issue38135] Depth first search in compile.c creates wrong BB order for certain CFG.

[Mark Shannon]

Mark Shannon  added the comment:

This seems to have been fixed sometime.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38135] Depth first search in compile.c creates wrong BB order for certain CFG.

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 99b54d68172ad64ba3d0fdc0137f0df88c28ea2b by Gregory P. Smith (T. 
Wouters) in branch 'master':
Revert "Fix depth-first-search computation in compile.c (GH-16042)" (GH-16050)
https://github.com/python/cpython/commit/99b54d68172ad64ba3d0fdc0137f0df88c28ea2b


--
nosy: +gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38135] Depth first search in compile.c creates wrong BB order for certain CFG.

[Thomas Wouters]

Change by Thomas Wouters :


--
pull_requests: +15672
pull_request: https://github.com/python/cpython/pull/16050

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38135] Depth first search in compile.c creates wrong BB order for certain CFG.

[Mark Shannon]

Change by Mark Shannon :


--
keywords: +patch
pull_requests: +15664
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16042

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38135] Depth first search in compile.c creates wrong BB order for certain CFG.

[Mark Shannon]

Change by Mark Shannon :


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38135] Depth first search in compile.c creates wrong BB order for certain CFG.

[Mark Shannon]

New submission from Mark Shannon :

Consider a flow graph of four nodes, A, B, C, D
where the A, B, C are "next" successors of each other (in order) and C branches 
to B and B branches to D. Note that there is no "next" link to the D block.

The correct order is A, B, C, D but the 'dfs' function in compile.c produces 
the order A, B, D, C.

This is not an issue with the current compiler as it always add the "next" link 
from C to D, but this will become an issue when we use a more powerful CFG 
based optimizer than the current "peephole" optimizer.

--
assignee: Mark.Shannon
components: Interpreter Core
messages: 352114
nosy: Mark.Shannon
priority: normal
severity: normal
status: open
title: Depth first search in compile.c creates wrong BB order for certain CFG.
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com